Fix FTBFS on Fedora and refresh RPM packaging#323
Conversation
On RPM based distributions, pycoverage has the binary name "coverage-3". Signed-off-by: Neal Gompa <[email protected]>
On most Linux distributions, systemd itself is installed in a UsrMerged configuration. This means that there's one more directory level to traverse for the symlink to work. Signed-off-by: Neal Gompa <[email protected]>
Conan-Kudo
force-pushed
the
refresh-rpm-build
branch
from
63942ba to
3a6e7ee
Compare
This brings the packaging more in line with what is shipped in Fedora. Due to the Meson requirement, the lowest version supported now is CentOS/RHEL 9. More specifically, Red Hat Enterprise Linux 9.2 will ship with a new enough Meson for building Netplan. Signed-off-by: Neal Gompa <[email protected]>
Conan-Kudo
force-pushed
the
refresh-rpm-build
branch
from
3a6e7ee to
454b72b
Compare
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you! I need to double check the systemd usrmerge situation in Debian/Ubuntu wrt. that meson.build change. Otherwise this LGTM!
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you very much for your repeated contributions @Conan-Kudo !
I think the main difference here is that systemd_generator_dir is different on different distros. This is a difference in systemd's (pkgconf) packaging.
# Ubuntu Lunar
root@ll:~# pkgconf --variable=systemdsystemgeneratordir systemd
/lib/systemd/system-generators
# Fedora 37
[root@f37 ~]# pkgconf --variable=systemdsystemgeneratordir systemd
/usr/lib/systemd/system-generators
Using an absolute target for the symbolic link sounds like a good idea! I'll fix that up after merging this PR.
|
Ugh.. apparently meson is not willing to install a dangling symlink, so I needed to revert this ea5530c and we'll need come up with something better. |
|
You might have to use a custom handler for installing symlinks instead of Meson's own thing. There's too many papercuts with Meson's |
|
Yeah... I'm currently investigating a few options/workarrounds, like |
3 participants
This pull request fixes Netplan to build on Fedora Linux and updates the RPM packaging to use the Meson build.