parse: fix the handle_match_driver type#257
Merged
schopin-pro merged 1 commit intocanonical:mainfrom Feb 2, 2022
Merged
Conversation
The YAML_NO_NODE type marker means that the callback called is via the `.variable` union field, not `.generic`. Since this is a union type, and both callbacks have the same signature for now, it works, but future evolutions of the code will make those signatures evolve independently, leading to hard-to-debug issues.
2 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The YAML_NO_NODE type marker means that the callback called is via the
.variableunion field, not.generic. Since this is a union type, andboth callbacks have the same signature for now, it works, but future
evolutions of the code will make those signatures evolve independently,
leading to hard-to-debug issues.
Checklist
make checksuccessfully.make check-coverage).