YAML consolidation prelude: High-level libnetplan bindings (FR-702)#250
Conversation
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 99.10% 99.11% +0.01%
==========================================
Files 58 60 +2
Lines 10078 10206 +128
==========================================
+ Hits 9988 10116 +128
Misses 90 90
Continue to review full report at Codecov.
|
schopin-pro
changed the title
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
I really like the way you're setting up the python bindings for libnetplan here.
I left a few comments inline that we should improve upon, but nothing big or critical.
This is another really sleek PR, thanks for that!
schopin-pro
force-pushed
the
yaml-consolidation-bindings-prelude
branch
4 times, most recently
from
60862fd to
fc4b8fa
Compare
The utils module was getting kind of crowded.
We're using the iterator as the introduction point of the transition, but the idea is to use these classes as the main way to interact with the C library. Note the temporary GlobalState class that has been introduced as a temporary measure. It should be gone by the end of the patchset. :) V2: * rename struct devtype_def_iter to netdef_pertype_iter
Co-authored-by: Lukas Märdian <[email protected]>
schopin-pro
force-pushed
the
yaml-consolidation-bindings-prelude
branch
from
fc4b8fa to
f55b847
Compare
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you! All remarks have been addressed, LGTM!
Merging.
3 participants
Description
This PR introduces some high-level Python bindings. This is mostly a skeleton that will be populated with the needed elements in later PRs, which will remain in draft state until this one is merged.
Checklist
make checksuccessfully.make check-coverage).