Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 98.98% 99.00% +0.01%
==========================================
Files 54 54
Lines 8215 8316 +101
==========================================
+ Hits 8132 8233 +101
Misses 83 83
Continue to review full report at Codecov.
|
slyon
force-pushed
the
slyon/networkctl-restart
branch
from
208d50b to
2b4f035
Compare
sil2100
approved these changes
Mar 23, 2021
Contributor
sil2100
left a comment
sil2100
left a comment
There was a problem hiding this comment.
Ok, this looks smooth. Thanks! (just one inline enhancement proposed)
make use of list.extend() instead of individual list.append()s Co-authored-by: Łukasz Zemczak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the calls of
systemctl stop/start systemd-networkd.servicewithnetworkctl reload && networkctl reconfigure ...during the execution ofnetplan apply. The devices to be reconfigured are currently all interfaces managed by systemd-networkd, as read fromnetworkctl. This makes the whole restart/apply process quicker and avoids network interruptions for netplan's networkd backend.The reload & reconfigure commands are available as of systemd v244.
In addition to the Apply-CLI changes, corresponding methods in
utils.pyare updated/refactored and the unit-test coverage is being improved.Checklist
make checksuccessfully.make check-coverage).