Fix 'networkmanager:' backend options for modem connections#179
Merged
Fix 'networkmanager:' backend options for modem connections#179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 49 49
Lines 7351 7356 +5
=======================================
+ Hits 7271 7276 +5
Misses 80 80
Continue to review full report at Codecov.
|
sil2100
approved these changes
Dec 16, 2020
Contributor
sil2100
left a comment
sil2100
left a comment
There was a problem hiding this comment.
Ok, this looks good. I mean, we don't support openvswitch: for modems, but it doesn't really matter.
slyon
added a commit
to slyon/netplan
that referenced
this pull request
May 21, 2024
5 tasks
slyon
added a commit
to slyon/netplan
that referenced
this pull request
May 21, 2024
slyon
added a commit
to slyon/netplan
that referenced
this pull request
May 21, 2024
slyon
added a commit
that referenced
this pull request
May 21, 2024
daniloegea
pushed a commit
that referenced
this pull request
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
COMMON_BACKEND_HANDLERShave been forgotten formodemconnections apparently. Add them to allow the definition of the specialnetworkmanager:mapping, used for NetworkManager integration. E.g. thisnetworkmanager.uuidsetting:We do not (yet) use that information (like uuid) in the current implementation. But reading YAML via NetworkManager will be broken if the
networkmanager:mapping is not accepted.Checklist
make checksuccessfully.make check-coverage).