Allow critical to be used without dhcp4/dhcp6 enabled#107
Allow critical to be used without dhcp4/dhcp6 enabled#107sil2100 merged 3 commits intocanonical:masterfrom
critical to be used without dhcp4/dhcp6 enabled#107Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 36 36
Lines 4159 4160 +1
=====================================
+ Hits 4159 4160 +1
Continue to review full report at Codecov.
|
sil2100
left a comment
sil2100
left a comment
There was a problem hiding this comment.
This looks good in overall - the only request for change is adding a generator unit test for the new combination, i.e. something like test_dhcp_critical_true, just in case of critical: yes while there is no dhcp4 or dhcp6 defined.
I see that with systemd 243 the CriticalConnection option has been deprecated and instead a KeepConfiguration added - we might keep that in mind and switch to it in the future. For now CriticalConnection is wrapping around KeepConfiguration, so it's still good to land.
|
Could you also merge latest trunk so that this is mergeable again? |
cedws
force-pushed
the
CriticalWithoutDHCP
branch
from
40204c1 to
d47443f
Compare
|
Thanks for taking a look. I saw that there's already a test for this option, so I just modified it to not require I might be able to help out with adding support for |
sil2100
left a comment
sil2100
left a comment
There was a problem hiding this comment.
I suppose we could have left the old test and added a new one to make sure it works for both cases, but actually this way is fine as well (since we know what we modified). Looks good from my POV - approving!
|
Great, thanks again. |
…tions (#505) * add prereq snippet * add disable netfilter snippet * add check networking delete default snippet * add create bridge network snippet * add system prereq snippet * doc: move reuse/*.txt to .md files This is for improved Markdown code highlighting. Also, update the conf.py to ignore/exclude reuse/*.md files.
…tions (#505) * add prereq snippet * add disable netfilter snippet * add check networking delete default snippet * add create bridge network snippet * add system prereq snippet * doc: move reuse/*.txt to .md files This is for improved Markdown code highlighting. Also, update the conf.py to ignore/exclude reuse/*.md files.
3 participants
Description
This change allows the
criticaloption to be used withoutdhcp4ordhcp6also being enabled. My understanding is that the underlying networkd optionCriticalConnectionalso can prevent static IPs being dropped, not just ones assigned via DHCP. In my case, I needed to prevent IPs being assigned by keepalived from being dropped.Checklist
make checksuccessfully.make check-coverage).