Skip to content

test: add e2e test for external instance file [WD-14777] #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mas-who merged 1 commit into from
Sep 30, 2024
Merged

test: add e2e test for external instance file [WD-14777] #929

mas-who merged 1 commit into from
Sep 30, 2024

Conversation

@mas-who
Copy link
Contributor

@mas-who mas-who commented Sep 26, 2024 •
edited
Loading

Done

  • add e2e for uploading external format instance file
  • fixed a bug where uploading external instance file to a lxd cluster fails

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Ensure CI passes

@webteam-app
Copy link

webteam-app commented Sep 26, 2024

Demo

Jenkins

demos.haus

@mas-who mas-who force-pushed the external-instance-file-e2e branch 2 times, most recently from 473d3d6 to 77347ac Compare September 26, 2024 11:30
@mas-who
Copy link
Contributor Author

mas-who commented Sep 26, 2024

@edlerd this one is ready for review :) picked up a bug for uploading an external instance file to a lxd cluster, that's also fixed in this PR

@mas-who mas-who force-pushed the external-instance-file-e2e branch 2 times, most recently from 0328a7a to 64128e2 Compare September 26, 2024 17:21
edlerd
edlerd reviewed Sep 27, 2024
View reviewed changes
@mas-who mas-who force-pushed the external-instance-file-e2e branch 2 times, most recently from bb9df85 to 7fdd177 Compare September 30, 2024 11:02
@mas-who mas-who requested a review from edlerd September 30, 2024 11:02
edlerd
edlerd requested changes Sep 30, 2024
View reviewed changes
@mas-who mas-who force-pushed the external-instance-file-e2e branch from 7fdd177 to 64e603d Compare September 30, 2024 11:20
edlerd
edlerd approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test and making it nice :)

@mas-who mas-who merged commit 358b978 into canonical:main Sep 30, 2024
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
workflow: remove all reports for PR #929
db31573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edlerd edlerd edlerd approved these changes

Assignees

No one assigned

Labels

Review: Code needed Review: QA needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mas-who @webteam-app @edlerd @MasWho