Merged
Conversation
simondeziel
reviewed
May 27, 2024
Member
|
@hamistao for this new test to be run, please add it to the list in https://github.com/canonical/lxd-ci/blob/main/.github/workflows/tests.yml#L79. Please keep the list sorted alphabetically, thx! |
added 3 commits
May 27, 2024 16:23
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
simondeziel
approved these changes
May 27, 2024
Member
simondeziel
left a comment
simondeziel
left a comment
There was a problem hiding this comment.
Failing everywhere as it should because canonical/lxd#13320 has yet to be merged.
Thanks!
Author
|
@simondeziel All done, thanks for the review! I also switched some comments for |
Member
Yep, that's good, thanks. |
tomponline
approved these changes
May 29, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding tests for basic TPM usage on VMs, with included tests for handling TPMs with long names (see #13320)