Skip to content

Fix USB device hotplugging - #19450

Open
jonathan-conder wants to merge 4 commits into
canonical:mainfrom
jonathan-conder:fix/usb-hotplug
Open

jonathan-conder wants to merge 4 commits into
canonical:mainfrom
jonathan-conder:fix/usb-hotplug

Conversation

@jonathan-conder

@jonathan-conder jonathan-conder commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #15730.

The first three commits are cherry-picked from lxc/incus#1949 and lxc/incus#4316.

The fourth commit is original; it adds a new test to prevent future regressions with USB device hotplugging.

Checklist

@tomponline

Copy link
Copy Markdown
Member

I didn't retain the original authorship

You need to retain the original signed-off line and add your own, you also need to add an Apache 2 license line, e.g.

git cherry-pick -x ...
git commit --amend -s --trailer License:Apache-2.0

@tomponline tomponline left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to attribute cherry-picks and license please

@jonathan-conder

Copy link
Copy Markdown
Contributor Author

You need to retain the original signed-off line and add your own, you also need to add an Apache 2 license line

I already had the license line; I was basing my commits on b6bd7ea but they are now based on ad1f02d, i.e. the original Signed-off-by and commit author are preserved. Also split the first commit up because it had 2 separate authors.

@jonathan-conder

Copy link
Copy Markdown
Contributor Author

hrm I also need to adjust the commit messages, one sec

@simondeziel

Copy link
Copy Markdown
Member

@jonathan-conder LGTM except for the dup signed-off-by for yourself.

stgraber and others added 3 commits November 13, 2026 09:59
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 5d6abd76d78f8fba991cef2271de17b65fc128db)
License: Apache-2.0
Signed-off-by: Jonathan Conder <[email protected]>
Signed-off-by: LucaCappelletti94 <[email protected]>
(cherry picked from commit c0096076949bff06f747707190fb75544d7377d0)
License: Apache-2.0
Signed-off-by: Jonathan Conder <[email protected]>
Signed-off-by: LucaCappelletti94 <[email protected]>
(cherry picked from commit 8e12d6d2c184c15c44f6d98013fb678f43fafcf8)
License: Apache-2.0
Signed-off-by: Jonathan Conder <[email protected]>
@simondeziel

Copy link
Copy Markdown
Member

@jonathan-conder please line wrap the last commit message.

Add an integration test that injects a synthetic kernel USB uevent and
checks that the device node appears in and disappears from a running
container.

Signed-off-by: Jonathan Conder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USB hotplug is unreliable

5 participants