lint: Fix errors reported by perfsprint: concat-loop#16857
Merged
tomponline merged 10 commits intocanonical:mainfrom Oct 30, 2025
Merged
lint: Fix errors reported by perfsprint: concat-loop#16857tomponline merged 10 commits intocanonical:mainfrom
perfsprint: concat-loop#16857tomponline merged 10 commits intocanonical:mainfrom
Conversation
Signed-off-by: Mark Laing <[email protected]>
markylaing
requested review from
kadinsayani,
roosterfish,
simondeziel and
tomponline
roosterfish
previously requested changes
Oct 30, 2025
tomponline
reviewed
Oct 30, 2025
Member
|
@markylaing looks like you've lost some implicit type |
Contributor
Author
|
Wowzer the tests really blew up! |
markylaing
force-pushed
the
perfsprint-concat-loop
branch
3 times, most recently
from
77652c4 to
9a767b1
Compare
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
perfsprint-concat-loop
branch
from
9a767b1 to
972d6b9
Compare
Contributor
Author
|
The CLA check is now failing 🤦 Other tests should pass now 🤞 |
Member
All green now. @markylaing OK to mark as ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are such micro-optimisations that I was tempted to just turn the rule off - but it's good to keep it on so that we write more efficient code in future.
The fixes aren't the most efficient that they could possibly be, as there are a lot of unnecessary fmt.Sprintf's remaining.