Storage: Revert "lxd/storage/drivers/generic/vfs: Truncate/Discard ahead of sparse write" #14794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arse write" This reverts commit ab910ac. It is causing failures with our LVM CI tests due to the additional time it takes to do a slow `blkdiscard --zeroout` run when resetting the volume after an initial snapshot is transferred. As the other commit in this PR deals with resetting the newly created volume, no old data from previously deleted volumes will be present, and this commit is just designed to ensure that "holes" of zeroes in the incoming data stream don't corrupt the volume when using the sparse writer. As we've not landed the sparse writer yet, all of the bytes from the incoming data stream are written to the volume and thus there is no issue. So we can hold off from landing this commit until we land the sparse writer. Signed-off-by: Thomas Parrott <[email protected]>
tomponline
changed the title
hamistao
approved these changes
Jan 14, 2025
hamistao
left a comment
hamistao
left a comment
There was a problem hiding this comment.
Thanks for the clear commit message :))
I was able to understand a process outside my comfort zone in a single read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ab910ac from #14761.
It is causing failures with our LVM CI tests due to the additional time it takes to do a slow
blkdiscard --zerooutrun when resetting the volume after an initial snapshot is transferred.As the other commit in this PR deals with resetting the newly created volume, no old data from previously deleted volumes will be present, and this commit is just designed to ensure that "holes" of zeroes in the incoming data stream don't corrupt the volume when using the sparse writer.
As we've not landed the sparse writer yet, all of the bytes from the incoming data stream are written to the volume and thus there is no issue.
So we can hold off from landing this commit until we land the sparse writer.