lxd-agent: If the target path of a mount is relative, make it absolute. #14792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the path is not absolute, the mount will be created at `/run/lxd_agent/<path>`, since the mount command executed below originates from the `lxd-agent` binary that is in the `/run/lxd_agent` directory. This is not ideal and not consistent with the way mounts are handled with containers. We then make the path absolute. Signed-off-by: Gabriel Mougard <[email protected]>
tomponline
approved these changes
Jan 14, 2025
Member
|
ta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13406
If the path is not absolute, the mount will be created at
/run/lxd_agent/<path>, since the mount command executed below originates from thelxd-agentbinary that is in the/run/lxd_agentdirectory. This is not ideal and not consistent with the way mounts are handled with containers. We then make the path absolute.The clean unmounting process will be handled in #12700