Repository navigation
ci: ignore unstable chisel releases - #683
Merged
cjdcordeiro merged 5 commits intoOct 2, 2025
Merged
Conversation
lczyk
changed the title
3 tasks done
cjdcordeiro
requested changes
Sep 30, 2025
lczyk
force-pushed
the
ROCKS-2504/add-ignore-unstable-mini
branch
from
September 30, 2025 16:03
4b3bf87 to
d060ddd
Compare
Collaborator
|
@lczyk do you confirm that these error are related with your ongoing work to bring 25.10 to an healthy state? |
lengau
reviewed
Oct 1, 2025
| logging.info("No slices will be installed.") | ||
| return | ||
|
|
||
| extra_flag = '--ignore=unstable' if subprocess.check_output(["chisel","version"]).strip().decode().lstrip("v") > "1.2.0" else '' |
There was a problem hiding this comment.
Wouldn't this affect a 1.2.1 release as well?
Collaborator
There was a problem hiding this comment.
yes, but there isn't one, and the "--ignore" code is already in main, so whatever the next version is, it will already support this flag
Collaborator
Author
yep. the fact that it got to the installation means that the bit that this is trying to fix is working |
3 tasks done
3 tasks done
cjdcordeiro
approved these changes
Oct 2, 2025
This was referenced Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
mini version of #676
Related issues/PRs
#676
Forward porting
n/a
Checklist