Skip to content

feat(24.04): revert ca certificates data - #310

Merged
cjdcordeiro merged 7 commits into
canonical:ubuntu-24.04from
zhijie-yang:ROCKS-1423/revert-ca-certs-data
Aug 19, 2024
Merged

cjdcordeiro merged 7 commits into
canonical:ubuntu-24.04from
zhijie-yang:ROCKS-1423/revert-ca-certs-data

Conversation

@zhijie-yang

@zhijie-yang zhijie-yang commented Aug 12, 2024 •

Copy link
Copy Markdown
Collaborator

Proposed changes

This PR reverts the changes in ca-certificates, to keep the original behaviour of ca-certificates_data, and moves the slice including the individual certificates in the ca-certificates_data-with-certs slice.

Related issues/PRs

ROCKS-1423

Forward porting

Not applicable

Checklist

@github-actions

github-actions Bot commented Aug 12, 2024 •

Copy link
Copy Markdown

Diff of dependencies:

slices/ca-certificates.yaml
@@ -1,3 +1,6 @@
-debconf
-debconf-2.0
+base-files
+bash
+coreutils
+findutils
 openssl
+sed

@zhijie-yang zhijie-yang changed the title Revert CA Certificates Data feat(24.04): revert ca certificates data Aug 12, 2024
@zhijie-yang
zhijie-yang force-pushed the ROCKS-1423/revert-ca-certs-data branch from e3c7803 to c33416d Compare August 12, 2024 11:34
@zhijie-yang
zhijie-yang marked this pull request as ready for review August 12, 2024 11:35
@zhijie-yang
zhijie-yang requested a review from a team August 12, 2024 11:35

@rebornplusplus rebornplusplus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Comment thread slices/ca-certificates.yaml Resolved

@rebornplusplus rebornplusplus left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, danke!

@cjdcordeiro cjdcordeiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for the other PRs (plus the missing dependency discussed over chat)

Comment thread slices/ca-certificates.yaml Resolved
Comment thread slices/ca-certificates.yaml Resolved
Comment thread slices/ca-certificates.yaml Resolved
Comment thread slices/ca-certificates.yaml Resolved
Comment thread slices/ca-certificates.yaml Resolved
@cjdcordeiro
cjdcordeiro self-requested a review August 19, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants