Repository navigation
feat(26.10): add gcc-13 slices for s390x ppc64le - #1134
Merged
Merged
Conversation
Forward port of canonical#1091 from ubuntu-24.04, rewritten for chisel format v3. The /usr/share/doc entry of a cpp-13-<triplet> package is a symlink whose target depends on how that package was built: gcc-13-base for the native build, gcc-13-<triplet>-base for the cross builds. The copyright slices are keyed by architecture accordingly, and the four gcc-13-<triplet>-base packages get copyright slices of their own.
The existing cpp-13 tests also learn about the two new spread runners, on which they are cross-compilation cases.
Matches the marker the binutils and cpp-15 slices carry, and makes it clear the entry is not the directory it looks like.
The ld-linux-*.so.* glob matches nothing on ppc64el and s390x, whose loaders are ld64.so.2 and ld64.so.1. Use the same lookup canonical#1090 gave the binutils tests, so all four cpp-13 suites agree. Nothing was failing: the value is only consumed on the native-architecture path, which never runs on those two runners.
Same bug and same fix as the cpp-13 slices this branch builds on: the /usr/share/doc entry of a gcc-13-<triplet> package is a symlink to gcc-13-base for the native build and to gcc-13-<triplet>-base for the cross builds, so pulling gcc-13-base unconditionally left it dangling everywhere but on the native architecture. Depends on the gcc-13-<triplet>-base slices added by the cpp-13 branch.
Both suites bailed out with "Unsupported architecture" there, which fails outright now that a change to these slices schedules them on all four runners. The arch lists match what gcc-15 already carries.
Three generations of these slices each spelled the same guidance differently. Adopt the wording gcc-15 carries.
Forward port of the remaining half of canonical#1092. The two new triplet slices follow gcc-15's, including the per-architecture copyright split the rest of this branch applies to the existing two. gcc-13.yaml gains the matching cc1 and gcc-13 entries, so gcc-13_gcc-13 -- the architecture-independent slice that carries /usr/bin/gcc-13 along with an assembler, a linker and cc1 -- resolves on all four architectures rather than only amd64 and arm64.
Copies of the gcc-15 suites, which already cover these two runners.
Obsolete since canonical/chisel#256, and its Unsupported architecture fallback fails outright on the s390x and ppc64le runners -- which a change to gcc-13.yaml now schedules. Same shape the gcc-15 test already has.
3 tasks done
|
Diff of dependencies: slices/gcc-13-aarch64-linux-gnu.yaml@@ -1,14 +1,4 @@
-binutils-aarch64-linux-gnu
-cpp-13-aarch64-linux-gnu
gcc-13-aarch64-linux-gnu-base
+gcc-13-base
libc6
-libcc1-0
-libgcc-13-dev-arm64-cross
-libgcc-s1
-libgmp10
-libisl23
-libmpc3
-libmpfr6
-libstdc++6
-libzstd1
-zlib1g
+libgcc-13-devslices/gcc-13-powerpc64le-linux-gnu.yaml@@ -1,14 +1,4 @@
-binutils-powerpc64le-linux-gnu
-cpp-13-powerpc64le-linux-gnu
+gcc-13-base
gcc-13-powerpc64le-linux-gnu-base
libc6
-libcc1-0
-libgcc-13-dev-ppc64el-cross
-libgcc-s1
-libgmp10
-libisl23
-libmpc3
-libmpfr6
-libstdc++6
-libzstd1
-zlib1g
+libgcc-13-devslices/gcc-13-s390x-linux-gnu.yaml@@ -1,14 +1,4 @@
-binutils-s390x-linux-gnu
-cpp-13-s390x-linux-gnu
+gcc-13-base
gcc-13-s390x-linux-gnu-base
libc6
-libcc1-0
-libgcc-13-dev-s390x-cross
-libgcc-s1
-libgmp10
-libisl23
-libmpc3
-libmpfr6
-libstdc++6
-libzstd1
-zlib1g
+libgcc-13-devslices/gcc-13-x86-64-linux-gnu.yaml@@ -1,14 +1,4 @@
-binutils-x86-64-linux-gnu
-cpp-13-x86-64-linux-gnu
gcc-13-base
+gcc-13-x86-64-linux-gnu-base
libc6
-libcc1-0
libgcc-13-dev
-libgcc-s1
-libgmp10
-libisl23
-libmpc3
-libmpfr6
-libstdc++6
-libzstd1
-zlib1gslices/gcc-13.yaml@@ -1,4 +1,11 @@
binutils
-cpp-13
+cpp-13-aarch64-linux-gnu
+cpp-13-powerpc64le-linux-gnu
+cpp-13-s390x-linux-gnu
+cpp-13-x86-64-linux-gnu
+gcc-13-aarch64-linux-gnu
gcc-13-base
+gcc-13-powerpc64le-linux-gnu
+gcc-13-s390x-linux-gnu
gcc-13-x86-64-linux-gnu
+libgcc-13-dev |
This was referenced Aug 5, 2026
gcc-13 slices for s390x ppc64le
Test CoverageAverage Total Coverage: 0% Arch: aarch64Coverage: 0.00%
|
lczyk
added a commit
to lczyk/chisel-releases
that referenced
this pull request
Sep 27, 2026
folds in canonical#1133 (cpp-13), canonical#1134 (gcc-13), canonical#1135 (cpp-14) and canonical#1136 (gcc-14), which add the s390x and ppc64le slices and let their tests run on those arches.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Both new standard-library tests omit a header needed to compile their intended infinity assertion.
1 open finding
What changed in this PR
This PR forward-ports GCC 13 slices for s390x and ppc64le to the Ubuntu 26.10 Chisel release. It also carries the prerequisite CPP 13 slices and addresses cross-architecture copyright symlinks from issue #1050.
Changes:
- Add GCC 13 and CPP 13 slice definitions for both architectures.
- Add integration tests and extend existing tests to recognize the new runners.
- Add cross-architecture copyright dependencies and clarify slice notes.
| File | Description |
|---|---|
| tests/spread/integration/gcc-13/test_hello.sh | Uses native architecture detection. |
| tests/spread/integration/gcc-13-x86-64-linux-gnu/test_std.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/gcc-13-x86-64-linux-gnu/test_print.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/gcc-13-x86-64-linux-gnu/test_hello.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/testfiles/test_std.h | Declares s390x standard-library checks. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/testfiles/test_std.c | Implements s390x standard-library checks. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/testfiles/hello.c | Provides an s390x compilation sample. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/test_std.sh | Tests s390x compilation and libraries. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/test_print.sh | Checks s390x GCC paths and settings. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/test_help_and_version.sh | Checks s390x GCC help and version. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/test_hello.sh | Tests an s390x compiled program. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/test_dump.sh | Checks s390x GCC configuration output. |
| tests/spread/integration/gcc-13-s390x-linux-gnu/task.yaml | Registers s390x GCC test variants. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/testfiles/test_std.h | Declares ppc64le standard-library checks. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/testfiles/test_std.c | Implements ppc64le standard-library checks. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/testfiles/hello.c | Provides a ppc64le compilation sample. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/test_std.sh | Tests ppc64le compilation and libraries. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/test_print.sh | Checks ppc64le GCC paths and settings. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/test_help_and_version.sh | Checks ppc64le GCC help and version. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/test_hello.sh | Tests a ppc64le compiled program. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/test_dump.sh | Checks ppc64le GCC configuration output. |
| tests/spread/integration/gcc-13-powerpc64le-linux-gnu/task.yaml | Registers ppc64le GCC test variants. |
| tests/spread/integration/gcc-13-aarch64-linux-gnu/test_std.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/gcc-13-aarch64-linux-gnu/test_print.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/gcc-13-aarch64-linux-gnu/test_hello.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/cpp-13-x86-64-linux-gnu/test_preprocessor.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/cpp-13-x86-64-linux-gnu/test_help.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/cpp-13-x86-64-linux-gnu/test_c_compiler.sh | Updates runner detection and linker lookup. |
| tests/spread/integration/cpp-13-s390x-linux-gnu/test_preprocessor.sh | Tests the s390x preprocessor. |
| tests/spread/integration/cpp-13-s390x-linux-gnu/test_help.sh | Tests s390x compiler help. |
| tests/spread/integration/cpp-13-s390x-linux-gnu/test_c_compiler.sh | Tests the s390x compilation pipeline. |
| tests/spread/integration/cpp-13-s390x-linux-gnu/task.yaml | Registers s390x CPP test variants. |
| tests/spread/integration/cpp-13-s390x-linux-gnu/question.c | Supplies s390x preprocessor input. |
| tests/spread/integration/cpp-13-s390x-linux-gnu/hello.c | Supplies s390x compilation input. |
| tests/spread/integration/cpp-13-powerpc64le-linux-gnu/test_preprocessor.sh | Tests the ppc64le preprocessor. |
| tests/spread/integration/cpp-13-powerpc64le-linux-gnu/test_help.sh | Tests ppc64le compiler help. |
| tests/spread/integration/cpp-13-powerpc64le-linux-gnu/test_c_compiler.sh | Tests the ppc64le compilation pipeline. |
| tests/spread/integration/cpp-13-powerpc64le-linux-gnu/task.yaml | Registers ppc64le CPP test variants. |
| tests/spread/integration/cpp-13-powerpc64le-linux-gnu/question.c | Supplies ppc64le preprocessor input. |
| tests/spread/integration/cpp-13-powerpc64le-linux-gnu/hello.c | Supplies ppc64le compilation input. |
| tests/spread/integration/cpp-13-aarch64-linux-gnu/test_preprocessor.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/cpp-13-aarch64-linux-gnu/test_help.sh | Recognizes new cross-architecture runners. |
| tests/spread/integration/cpp-13-aarch64-linux-gnu/test_c_compiler.sh | Updates runner detection and linker lookup. |
| slices/gcc-13.yaml | Connects GCC 13 to the new architecture slices. |
| slices/gcc-13-x86-64-linux-gnu.yaml | Clarifies usage and copyright dependencies. |
| slices/gcc-13-x86-64-linux-gnu-base.yaml | Adds cross-architecture copyright content. |
| slices/gcc-13-s390x-linux-gnu.yaml | Defines the s390x GCC slice. |
| slices/gcc-13-s390x-linux-gnu-base.yaml | Adds s390x base copyright content. |
| slices/gcc-13-powerpc64le-linux-gnu.yaml | Defines the ppc64le GCC slice. |
| slices/gcc-13-powerpc64le-linux-gnu-base.yaml | Adds ppc64le base copyright content. |
| slices/gcc-13-aarch64-linux-gnu.yaml | Clarifies usage and copyright dependencies. |
| slices/gcc-13-aarch64-linux-gnu-base.yaml | Adds cross-architecture copyright content. |
| slices/cpp-13-x86-64-linux-gnu.yaml | Corrects copyright dependencies. |
| slices/cpp-13-s390x-linux-gnu.yaml | Defines the s390x CPP slice. |
| slices/cpp-13-powerpc64le-linux-gnu.yaml | Defines the ppc64le CPP slice. |
| slices/cpp-13-aarch64-linux-gnu.yaml | Corrects copyright dependencies. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lczyk
added a commit
to lczyk/chisel-releases
that referenced
this pull request
Oct 8, 2026
rebuild the combined tree on ubuntu-26.10 at 6f8ff36: the base, every fix PR that is still open at its current head, and this PR's .github changes. most of the folded PRs have merged since, so their final versions now come from the base, and the closed canonical#1272 drops out. refreshed: canonical#1134 e81efa4, canonical#1135 b3ebb7f, canonical#1136 3306393, canonical#1269 cfdcb2f, canonical#1276 32dc67d, canonical#1285 3a4909c, canonical#1318 c545c79, canonical#1319 2707f9e, canonical#1320 d374a9a, canonical#1322 3460f1b, canonical#1345 e41d87a. added: canonical#1359 a167fff. unchanged: canonical#1126, canonical#1176 (mesa slices only), canonical#1268, canonical#1310, canonical#1317, canonical#1321, canonical#1346.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes
carbon-copy of #1130
as on 26.04, this branch is built on top of its cpp counterpart, so until that one merges the diff here carries its commits too.
Related issues/PRs
gcc/cpp-*-<arch>have dangling symlinks #1050gcc-14slices for s390x ppc64le #1136gcc-15copyright on cross arches #1138Forward porting
part of:
cpp-13slices for s390x ppc64le #1127gcc-13slices for s390x ppc64le #1130cpp-13slices for s390x ppc64le #1133gcc-13slices for s390x ppc64le #1134 (this PR)Checklist
Additional Context
26.10 is in devel mode and chisel does not, at the moment, support 26.10. hence, the 26.10 branch is just being kept up to date with 26.04. the state of this branch vs its 26.04 version ought to be identical. the commit history can be checked with:
$ git range-diff --no-patch \ canonical/ubuntu-26.04..lczyk/feat/26.04/gcc-13 \ canonical/ubuntu-26.10..lczyk/feat/26.10/gcc-13 1: 60f0741a = 1: 5ed71334 feat(26.04): add cpp-13 slices for s390x and ppc64le 2: 6566d839 = 2: 05e4e3be test(26.04): add integration tests for cpp-13 on s390x and ppc64le 3: 38b1a15c = 3: f314ba9c docs(26.04): mark cpp-13 copyright paths as symlinks 4: eee94150 = 4: 81dc0139 test(26.04): fix dynamic linker lookup in the cpp-13 tests 5: b6450339 = 5: 1d5f523e fix(26.04): dangling gcc-13 copyright on cross arches 6: b2649e11 = 6: 52c5a008 test(26.04): run the gcc-13 tests on the s390x and ppc64le runners 7: 5659e41b = 7: d9b860ac docs(26.04): align the gcc-13 slice notes with gcc-15 8: 12815328 = 8: d131186d feat(26.04): add gcc-13 slices for s390x and ppc64le 9: 9b790f07 = 9: d775c20d test(26.04): add integration tests for gcc-13 on s390x and ppc64le 10: b6afdca3 = 10: 5f20d454 test(26.04): drop the chisel_arch workaround from the gcc-13 testand the diff of the entire branch with: