Skip to content

Commit 73a9150

Browse files
authored
chore(26.10): disable manifest cuts in spread (#1180)
* chore(26.10)!: temp disable manifest cuts in spread Manifest generation hardcodes the per-package sha256, so on the sha512-only stonking archive every chisel cut that includes base-files_chisel dies with 'invalid manifest: package "base-files" missing sha256'. Since install-slices always appends that slice, every spread task fails. Comment it out to unblock the branch, and guard the export on the manifest actually existing so the copy does not fail the run. The manifest is the input to the coverage report, so coverage will report 0% until this is reverted. Revert once chisel 1.5.1 lands with the fix for canonical/chisel#305. * chore: clarify sha512-only archive workaround comment rewording and TODO marker to better surface what's being worked around and where to look when the upstream chisel fix lands.
1 parent 5637f36 commit 73a9150

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

‎tests/spread/lib/install-slices‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,11 @@ trap 'rm -f "$_OUTPUT"' EXIT
1515

1616
function main() {
1717
local slices="$*"
18+
# TODO: manifest generation is broken on sha512-only archives. restore the
19+
# line below once https://github.com/canonical/chisel/issues/305 is fixed.
20+
1821
# add base-files_chisel slice to ensure we generate the manifest
19-
slices="${slices} base-files_chisel"
22+
# slices="${slices} base-files_chisel"
2023

2124
# chrooted daemons that drop privileges need the path to stay traversable
2225
#shellcheck disable=SC2174 # the parent always exists, only the leaf is created
@@ -25,7 +28,7 @@ function main() {
2528
local rootfs
2629
rootfs="$(mktemp -d -p "$ROOTFS_DIR")"
2730
chisel_cut "$rootfs" "$slices"
28-
if [ -n "$MANIFESTS_EXPORT_DIR" ]; then
31+
if [ -n "$MANIFESTS_EXPORT_DIR" ] && [ -f "$rootfs/var/lib/chisel/manifest.wall" ]; then
2932
export_manifests "$rootfs" "$MANIFESTS_EXPORT_DIR"
3033
fi
3134

0 commit comments

Comments
 (0)