Repository navigation
refactor: PackageInfo interface - #320
Merged
Merged
Conversation
This was referenced Aug 18, 2026
niemeyer
approved these changes
Aug 31, 2026
niemeyer
left a comment
niemeyer
left a comment
Contributor
There was a problem hiding this comment.
This looks like a nice step forward and aligns with the previous discussions.
Thanks for nailing it.
niemeyer
reviewed
Aug 31, 2026
Comment on lines
+21
to
+25
| type PackageInfo interface { | ||
| PkgName() string | ||
| PkgVersion() string | ||
| // PkgRevision further identifies the package when the source versions are | ||
| // not unique on their own. It returns 0 when the source does not use |
Contributor
There was a problem hiding this comment.
One detail to be discussed here: manifestutil feels like a strange place for this, in principle, as this is a general interface used across the board. Let's see if we can find a better place please.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
manifestutil.PackageInfointerface to keep a clear separation of concerns: the manifest is built from whatever a package source reports, not from archive-specific data. As a result,manifestutilno longer depends onarchive;archive.PackageInfokeeps its apt-native fields and gainsPkg-prefixed accessors to satisfy the interface.validatePackagenow rejects non-SHA256 digests, with a TODO marking recording store digests as future work. This prepares fetching and recording of store bins without changing current behavior.