Repository navigation
ci: drop rocksbot for collaborators list - #309
Merged
Merged
Conversation
upils
suggested changes
Jul 8, 2026
upils
left a comment
upils
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @cjdcordeiro! I have a couple of suggestions and questions but overall it seems to be safer, easier to maintain to more robust than the previous solution.
If we are happy with it we may want to do the same with the Security workflow.
lczyk
approved these changes
Jul 8, 2026
Co-authored-by: Upils <[email protected]>
Re-word the new CI job comments
niemeyer
approved these changes
Aug 7, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a CI security enhancement.
In #284, we improved the security of the
buildCI workflow, ensuring the whole CI job wouldn't have unnecessarywritepermissions to the repository, instead shifting towards a fine grained personal token that would only be used within a single, conditional step that only ran on GitHubreleaseevents.NEW: this PR goes one step further by removing the need to have a bot account (which owns the aforementioned fine grained personal token) with
writepermissions in the repository's collaborators list. Instead, this PR splits the privileged step into a separate privileged job. This means the new job can use the ephemeral GITHUB_TOKEN to perform the privileged step, without giving unnecessary privileges to other jobs&steps of the workflow.closes #308