Skip to content

ci: fix snap promote revision parsing - #304

Merged
niemeyer merged 2 commits into
canonical:mainfrom
upils:fix-release-promoting
Jul 10, 2026
Merged

niemeyer merged 2 commits into
canonical:mainfrom
upils:fix-release-promoting

Conversation

@upils

@upils upils commented Jun 30, 2026 •

Copy link
Copy Markdown
Collaborator
  • Have you signed the CLA?

Since Snapcraft 8.12, track and arch are repeated on each line of snapcraft status when piping the output.
See canonical/snapcraft#5720

This fix get the right field from the awk parsing.

Since Snapcraft 8.12, track and arch are repeated on each line of
`snapcraft status` when piping the output.
See canonical/snapcraft#5720

This fix get the right field from the awk parsing.
@upils upils added Simple Nice for a quick look on a minute or two Bug An undesired feature ;-) labels Jun 30, 2026
@upils upils assigned cjdcordeiro and unassigned cjdcordeiro Jun 30, 2026
@upils
upils requested a review from cjdcordeiro June 30, 2026 14:27

@cjdcordeiro cjdcordeiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

I'd also suggest pinning the snapcraft version then. Cause otherwise the same can happen in the future

@upils

upils commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

I'd also suggest pinning the snapcraft version then. Cause otherwise the same can happen in the future

As discussed offline: in that situation, pinning to a channel (8.X in that case) would not have solved the issue as this change in behavior happened between 8.11 and 8.12 (but I agree that should probably not have happened). Also, the suggestion to pin a specific version seems risky to me as there is no guarantee from the store that an old revision not associated to a track will be kept. If we were to do that, we would also risk failing if the revision disappears.

I also think it would not incentivise us to keep up with updated behaviors of Snapcraft. As Snapcraft is one of our projects I am more inclined to dog-food than pin a specific "good" version.

BTW the last step of this job could also now be reworked as Snapcraft 9.0 now allows promoting a snap from latest/edge with the --yes flag, making it doable in CI (see canonical/snapcraft#5984)

@upils
upils requested a review from cjdcordeiro July 10, 2026 07:51

@niemeyer niemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@niemeyer
niemeyer merged commit 3323d36 into canonical:main Jul 10, 2026
18 checks passed
@ROCKsBot

ROCKsBot commented Jul 14, 2026 •

Copy link
Copy Markdown
Command Mean [s] Min [s] Max [s] Relative
BASE 14.851 ± 0.092 14.692 14.999 1.00
HEAD 14.926 ± 0.030 14.870 14.963 1.01 ± 0.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An undesired feature ;-) Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants