Skip to content

fix: duplicate slice test + message - #268

Merged
niemeyer merged 1 commit into
canonical:mainfrom
lczyk:duplicate-slice-message
Mar 16, 2026
Merged

niemeyer merged 1 commit into
canonical:mainfrom
lczyk:duplicate-slice-message

Conversation

@lczyk

@lczyk lczyk commented Mar 3, 2026

Copy link
Copy Markdown
Contributor
  • Have you signed the CLA?

  • remove needless \") from duplicate slices message
  • add stripBase to have only relative slice path in the message

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Command Mean [s] Min [s] Max [s] Relative
BASE 13.334 ± 0.066 13.228 13.448 1.00
HEAD 13.335 ± 0.090 13.219 13.538 1.00 ± 0.01

@lczyk
lczyk requested a review from upils March 3, 2026 22:41
@lczyk lczyk added Simple Nice for a quick look on a minute or two Polish Refactorings, etc labels Mar 3, 2026

@upils upils left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Also thanks for adding the missing test.

@niemeyer niemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@niemeyer
niemeyer merged commit a1ff2d4 into canonical:main Mar 16, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Polish Refactorings, etc Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants