Repository navigation
bugfix: revert disabling TopLevelControl - #214
Merged
Merged
Conversation
TopLevelControl was disabled accidentally on canonical#211. The old Starlark API had it enabled by default and the new one does not.
3 tasks done
|
cjdcordeiro
approved these changes
Apr 3, 2025
cjdcordeiro
added
Simple
niemeyer
approved these changes
Apr 4, 2025
niemeyer
left a comment
niemeyer
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix and testing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopLevelControl was disabled accidentally on #211. The old Starlark API had it enabled by default and the new one does not.
Bug found on chisel-releases CI when testing all packages against main (action failure).