Skip to content

feat: add performance testing in the ci - #196

Merged
niemeyer merged 3 commits into
canonical:mainfrom
letFunny:performance-benchmark-ci
Feb 4, 2025
Merged

niemeyer merged 3 commits into
canonical:mainfrom
letFunny:performance-benchmark-ci

Conversation

@letFunny

Copy link
Copy Markdown
Collaborator
  • Have you signed the CLA?

@letFunny

letFunny commented Jan 24, 2025 •

Copy link
Copy Markdown
Collaborator Author

We have to configure the repo to have the correct permissions in "Settings". It works in mine out of the box: letFunny#26.

Probably not sending write permissions with the GITHUB_TOKENS to PRs from forks.

EDIT: Should work out of the box, just tested it in another repo.

@niemeyer niemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just trivial detail and LGTM.

Comment thread .github/workflows/performance.yaml Outdated
benchmark-info:
runs-on: ubuntu-22.04
needs: build
name: Benchmark chisel info (24.04)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22.04, or 24.04?

@niemeyer
niemeyer merged commit c4bb322 into canonical:main Feb 4, 2025
@letFunny
letFunny deleted the performance-benchmark-ci branch April 30, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants