Repository navigation
Inject copyright file into slices - #18
Conversation
cjdcordeiro
left a comment
cjdcordeiro
left a comment
There was a problem hiding this comment.
lgtm.
tested with multiple slices, both with and without copyright files.
One question though: what about common-licenses? Some packages might refer to a common license instead of having it explicit within their content...should base-files /usr/share/common-licenses always be installed by default? I think there are still a lot of packages where the copyright files are not machine readable, so it's not like we could infer their connection to a common-license...any thoughts on this?
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is looking quite nice.
A few minor points:
Add /usr/share/doc/<package>/copyright file entry to every slice to make sure copyright files are always included in the final tree. Stripped out base-files package that is embedded in pkgdata.go is modified to include the copyright file and slicer_test.go is modified to inject copyright filesystem entries in expected test result map.
|
@niemeyer I've addressed all your comments. Can you please look again?
The package copyright files seems to include complete verbatim licenses already for various parts of source code, so |
niemeyer
left a comment
niemeyer
left a comment
There was a problem hiding this comment.
The testing approach means it's assuming every test is base-files and has that exact copyright, which is not great. That said, this PR has waited enough and the actual implementation here is now small and sweet, so let's move on with it and we can address the test later when the time comes.
Thanks for the change and patience.
Add /usr/share/doc/<package>/copyright file entry to every slice to make sure copyright files are always included in the final tree. Stripped out base-files package that is embedded in pkgdata.go is modified to include the copyright file and slicer_test.go is modified to inject copyright filesystem entries in expected test result map.
Add /usr/share/doc//copyright file entry to every slice to make
sure copyright files are always included in the final tree. The entry is
added with new Optional flag that's not exposed in public YAML interface,
but is passed down to ExtractInfo.Optional flag. Note that we allow same
entries in multiple slices as long as they have same properties (kind,
mode, etc.).
Stripped out base-files package that is embedded in pkgdata.go is modified
to include the copyright file in and slicer_test.go is modified to inject
copyright filesystem entries in expected test result map.