Skip to content

refactor(setup): move YAML-specific logic to yaml.go - #169

Merged
niemeyer merged 3 commits into
canonical:mainfrom
letFunny:move-yaml-to-file
Nov 22, 2024
Merged

refactor(setup): move YAML-specific logic to yaml.go#169
niemeyer merged 3 commits into
canonical:mainfrom
letFunny:move-yaml-to-file

Conversation

@letFunny

@letFunny letFunny commented Oct 24, 2024

Copy link
Copy Markdown
Collaborator
  • Have you signed the CLA?

@letFunny letFunny added Simple Nice for a quick look on a minute or two Polish Refactorings, etc labels Oct 24, 2024
@letFunny

letFunny commented Oct 24, 2024

Copy link
Copy Markdown
Collaborator Author

Verified that we are only moving code by using git diff --color-moved HEAD~.

niemeyer
niemeyer approved these changes Nov 22, 2024
View reviewed changes

@niemeyer niemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reorg!

@niemeyer
niemeyer merged commit b45d61f into canonical:main Nov 22, 2024
@letFunny
letFunny deleted the move-yaml-to-file branch January 21, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niemeyer niemeyer niemeyer approved these changes

Assignees

No one assigned

Labels

Polish Refactorings, etc Simple Nice for a quick look on a minute or two

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@letFunny @niemeyer