Skip to content

chore: publish release checksums - #155

Merged
cjdcordeiro merged 5 commits into
canonical:mainfrom
rebornplusplus:chore/publish-release-checksum
Sep 26, 2024
Merged

cjdcordeiro merged 5 commits into
canonical:mainfrom
rebornplusplus:chore/publish-release-checksum

Conversation

@rebornplusplus

@rebornplusplus rebornplusplus commented Aug 28, 2024 •

Copy link
Copy Markdown

On release events, publish checksum of the binary tarballs that we already publish.

Closes #122.

@rebornplusplus
rebornplusplus marked this pull request as ready for review August 28, 2024 14:42

@cjdcordeiro cjdcordeiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ;)

Just a couple of small corrections/improvements

Comment thread .github/workflows/build.yml Resolved
Comment thread .github/workflows/build.yml Resolved
@cjdcordeiro cjdcordeiro added the Simple Nice for a quick look on a minute or two label Aug 30, 2024
Rafid Bin Mostofa added 2 commits August 30, 2024 15:01
The goal is to improve maintainability, because ``dist/`` was hardcoded
in multiple steps.

@cjdcordeiro cjdcordeiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the changes

@cjdcordeiro cjdcordeiro self-assigned this Sep 26, 2024
@cjdcordeiro
cjdcordeiro merged commit ac90003 into canonical:main Sep 26, 2024
@cjdcordeiro

Copy link
Copy Markdown
Collaborator

Discussed offline and deemed ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checksums for release assets?

2 participants