Repository navigation
refactor: filter created entries for report - #124
Merged
Merged
Conversation
To make the content transparent and facilitate changing the package, this commit creates the deb used for testing programmatically instead of embedding it as a base64-encoded blob directly.
The entries not mentioned explicitly in the slice definition will not be added to the report (e.g. copyright, parent directories). Additionally, we have removed the Globbed option and simplified it.
letFunny
force-pushed
the
chisel-db-report-filter
branch
from
March 6, 2024 10:51
2e39b33 to
b2d22d9
Compare
rebornplusplus
suggested changes
Mar 7, 2024
letFunny
commented
Mar 8, 2024
| Path: o.Path, | ||
| Mode: o.Mode, | ||
| Hash: hex.EncodeToString(rp.h.Sum(nil)), | ||
| Hash: hash, |
Collaborator
Author
There was a problem hiding this comment.
This is just a cosmetic change so the hash of folders is an empty string.
letFunny
commented
Mar 8, 2024
| "/dir/text-file-3": "file 0644 5b41362b {test-package_myslice}", | ||
| }, | ||
| }, { | ||
| summary: "Copyright is installed", |
Collaborator
Author
There was a problem hiding this comment.
I had to remove the copyright and move it to a separate test because testing several packages was getting too complex and magical.
Contributor
There was a problem hiding this comment.
Sounds good, thanks for doing that.
niemeyer
requested changes
Mar 8, 2024
niemeyer
left a comment
niemeyer
left a comment
Contributor
There was a problem hiding this comment.
This is looking great, Alberto, thank you.
A few minor details only.
| "/dir/text-file-3": "file 0644 5b41362b {test-package_myslice}", | ||
| }, | ||
| }, { | ||
| summary: "Copyright is installed", |
Contributor
There was a problem hiding this comment.
Sounds good, thanks for doing that.
1 task done
niemeyer
approved these changes
Apr 1, 2024
niemeyer
left a comment
niemeyer
left a comment
Contributor
There was a problem hiding this comment.
Thanks again for the changes.
niemeyer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entries not mentioned explicitly in the slice definition will not be
added to the report (e.g. copyright, parent directories). Additionally,
we have removed the Globbed option and simplified it.
This PR depends on #113.