refactor: Introduce _read_list_files_in_directory() helper#92
Closed
bdrung wants to merge 1 commit intocanonical:mainfrom
Closed
refactor: Introduce _read_list_files_in_directory() helper#92bdrung wants to merge 1 commit intocanonical:mainfrom
bdrung wants to merge 1 commit intocanonical:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 80.75% 80.76% +0.01%
==========================================
Files 84 84
Lines 17742 17736 -6
==========================================
- Hits 14328 14325 -3
+ Misses 3414 3411 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Avoid code duplication in `Report.check_ignored` by factoring out the list files reading into `_read_list_files_in_directory`. Signed-off-by: Benjamin Drung <[email protected]>
bdrung
force-pushed
the
read-list-files
branch
from
875b3a0 to
619c885
Compare
Contributor
|
Closing as this was already merged as part of #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid code duplication in
Report.check_ignoredby factoring out the list files reading into_read_list_files_in_directory.