feat: Replace blacklist.d/whitelist.d by report-ignore/report-only directories#58
feat: Replace blacklist.d/whitelist.d by report-ignore/report-only directories#58schopin-pro merged 2 commits intocanonical:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 80.75% 80.77% +0.01%
==========================================
Files 84 84
Lines 17742 17739 -3
==========================================
Hits 14328 14328
+ Misses 3414 3411 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bdrung
changed the title
bdrung
force-pushed
the
woke2
branch
2 times, most recently
from
aac7d57 to
e09c920
Compare
|
Code-wise LGTM, but thinking a bit more about deny vs ignore, I'm actually reverting my opinion back to ignore. The issue with I can understand it as "I deny this binary the right to crash, so you MUST report it", which is basically the semantics of the current "whitelist", or "I deny this binary the right to report the crashes". OTOH, we have the same issue with allow, and I don't have a good word for it. So maybe we could just have "report-deny" and "report-allow" to make it clearer what we're denying/allowing? |
|
Thanks for the feedback. Ideas: ignore/report or ignore/process? |
|
Sounds a bit silly but I would suggest |
|
"If something is defined in /etc/apport/whitelist.d/, everything which does not match gets ignored then." |
|
Perhaps "include/exclude"? The context is essentially filtration after all.
This sounds like an excellent suggestion to me. It's a bit more wordy, but explicit is better than implicit; it also makes the filtration context more obvious. Thumbs up for "fix it with more words!" |
|
include/exclude or include/ignore sounds good enough. clang-format uses woke itself uses |
|
So we have some options:
|
|
If no-one objects, I will change it to option 2: report-ignore / report-only. |
Avoid code duplication in `Report.check_ignored` by factoring out the list files reading into `_read_list_files_in_directory`. Signed-off-by: Benjamin Drung <[email protected]>
…rectories The words `blacklist` and `whitelist` may be insensitive. Therefore rename the directory `/etc/apport/blacklist.d` to `/etc/apport/report-ignore` and `/etc/apport/whitelist.d` to `/etc/apport/report-only`. Keep reading the old directories for backward compatibility until Apport 3.0. Signed-off-by: Benjamin Drung <[email protected]>
bdrung
changed the title
|
Ooooh I really like "report-only" :) |
5 participants
The words
blacklistandwhitelistmay be insensitive. Therefore rename the directory/etc/apport/blacklist.dto/etc/apport/report-ignoreand/etc/apport/whitelist.dto/etc/apport/report-only. Keep reading the old directories for backward compatibility until Apport 3.0.This merge request contains the commit from #92: Avoid code duplication in
Report.check_ignoredby factoring out the list files reading into_read_list_files_in_directory.