Skip to content

Add propertyDefaults for class fields #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cherifGsoul merged 1 commit into from
Jun 18, 2020
Merged

Add propertyDefaults for class fields #85

cherifGsoul merged 1 commit into from
Jun 18, 2020

Conversation

@cherifGsoul
Copy link
Member

@cherifGsoul cherifGsoul commented Jun 18, 2020

Fixes propertyDefaults for observable class fields:

class MyArray extends ObservableArray {

  foo = 4;

  static get propertyDefaults() {
    return type.maybeConvert(String);
  }
}

const anArray = new MyArray();

console.log(anArray.foo); // '4'

anArray.on('foo', (ev, newVal, oldVal) => {
  console.log(newVal); // -> '10'
});

anArray.set(foo, 10);

@cherifGsoul cherifGsoul merged commit 87a8089 into master Jun 18, 2020
@cherifGsoul cherifGsoul deleted the class-fields-propertyDefaults branch June 18, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phillipskevin phillipskevin phillipskevin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cherifGsoul @phillipskevin