Skip to content

Fix mutation with 0 value event dispatching #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cherifGsoul merged 1 commit into from
May 19, 2020
Merged

Fix mutation with 0 value event dispatching #80

cherifGsoul merged 1 commit into from
May 19, 2020

Conversation

@cherifGsoul
Copy link
Member

@cherifGsoul cherifGsoul commented May 19, 2020

Fix event dispatching when an item gets mutated with 0 integer value:

const order = new ObservableArray([0, 1]);
canReflect.onPatches(order, (patches) => {
       console.log(order[1]); // -> 0
});
order[1] = 0;

Fixes #79

@cherifGsoul cherifGsoul requested a review from phillipskevin May 19, 2020 20:30
phillipskevin
phillipskevin approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cherifGsoul cherifGsoul merged commit 1c50a7d into master May 19, 2020
@cherifGsoul cherifGsoul deleted the zero-indx-dispatch-index-event branch May 19, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phillipskevin phillipskevin phillipskevin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Events for mutation with 0 integer value are disptached

3 participants

@cherifGsoul @phillipskevin