Skip to content

Add class field support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cherifGsoul merged 5 commits into from
Jun 11, 2020
Merged

Add class field support #78

cherifGsoul merged 5 commits into from
Jun 11, 2020

Conversation

@cherifGsoul
Copy link
Member

@cherifGsoul cherifGsoul commented Apr 17, 2020

For example:

class Person extends ObservableArray{
		greetings = 'Hello';
}

const cherif = new Person();

cherif.on('greetings', function (ev, newVal, oldVal) {
	    // it should be observable, handle change here
});

// Property change trigger the handler
cherif.greetings = 'Hola';

For canjs/can-observable-mixin#79

phillipskevin
phillipskevin requested changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cherifGsoul, I still don't see the docs. Maybe you forgot to push them?

@cherifGsoul
Copy link
Member Author

cherifGsoul commented Jun 4, 2020

Hi @cherifGsoul, I still don't see the docs. Maybe you forgot to push them?

Yeah I found the commit waiting to be pushed :/

@cherifGsoul cherifGsoul requested a review from phillipskevin June 4, 2020 18:07
@cherifGsoul
Copy link
Member Author

cherifGsoul commented Jun 4, 2020

@phillipskevin The docs are updated, can you review one more time?

phillipskevin
phillipskevin approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@cherifGsoul cherifGsoul merged commit 138cbe9 into master Jun 11, 2020
@cherifGsoul cherifGsoul deleted the observable-class-field-support branch June 11, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phillipskevin phillipskevin phillipskevin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cherifGsoul @phillipskevin