Skip to content

Conversation

@houssain-barouni
Copy link
Collaborator

@houssain-barouni houssain-barouni commented Feb 28, 2025

Description

This PR addresses a recent issue where the Tasklist application failed to start due to changes that were merged without being blocked by the Tasklist Docker tests workflow, as it is not a required check.

To avoid that, we are integrating Tasklist Docker tests into the common CI. This includes:

  • Building the full project (excluding the frontend and Optimize)
  • Building the Tasklist Docker image and pushing it to a local registry
  • Running a Docker test that starts a Tasklist container and performs basic sanity checks

The job takes around 8-9 minutes in average, I set the timeout to 15 minutes

This will replace the existing build-tasklist-backend job in the common CI, as it contains similar steps.

Checklist

Related issues

closes #

@github-actions github-actions bot added component/build-pipeline component/tasklist Related to the Tasklist component/team labels Feb 28, 2025
@houssain-barouni houssain-barouni force-pushed the tasklist-docker-tests branch 2 times, most recently from da23fe5 to 7616618 Compare February 28, 2025 16:51
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@houssain-barouni houssain-barouni force-pushed the tasklist-docker-tests branch 6 times, most recently from 1b26a5c to 16ee695 Compare March 3, 2025 05:44
@houssain-barouni houssain-barouni requested review from a team and cmur2 March 3, 2025 05:53
@houssain-barouni houssain-barouni marked this pull request as ready for review March 3, 2025 05:54
@houssain-barouni houssain-barouni force-pushed the tasklist-docker-tests branch 2 times, most recently from b99ebf1 to 4e1cf60 Compare March 3, 2025 06:45
Copy link
Member

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@cmur2
Copy link
Member

cmur2 commented Mar 3, 2025

I will have a look but might not make it today since I'm feeling sick-ish.

enable backports when recommended

Do you think backporting to stable 8.6 and 8.7 makes sense for this? Those branches also have the Unified CI and no required Tasklist status check.

@houssain-barouni
Copy link
Collaborator Author

I will have a look but might not make it today since I'm feeling sick-ish.

There is no urgency, Get Well Soon!

Do you think backporting to stable 8.6 and 8.7 makes sense for this? Those branches also have the Unified CI and no required Tasklist status check.

yes, it makes sense to backport it.

@houssain-barouni houssain-barouni added backport stable/8.6 Backport a pull request to stable/8.6 backport stable/8.7 Backport a pull request to stable/8.7 labels Mar 3, 2025
Copy link
Member

@cmur2 cmur2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

@houssain-barouni houssain-barouni added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@houssain-barouni houssain-barouni added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 0532bd9 Mar 3, 2025
137 of 138 checks passed
@houssain-barouni houssain-barouni deleted the tasklist-docker-tests branch March 3, 2025 14:05
@backport-action
Copy link
Collaborator

Created backport PR for stable/8.6:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-29005-to-stable/8.6
git worktree add --checkout .worktree/backport-29005-to-stable/8.6 backport-29005-to-stable/8.6
cd .worktree/backport-29005-to-stable/8.6
git reset --hard HEAD^
git cherry-pick -x 428d7afe243fc253b34bdd6b7a611201edb7c5a2 335ee99a4aae9522d55220b1a17b14a9e0a98b9b
git push --force-with-lease

@backport-action
Copy link
Collaborator

Created backport PR for stable/8.7:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-29005-to-stable/8.7
git worktree add --checkout .worktree/backport-29005-to-stable/8.7 backport-29005-to-stable/8.7
cd .worktree/backport-29005-to-stable/8.7
git reset --hard HEAD^
git cherry-pick -x 428d7afe243fc253b34bdd6b7a611201edb7c5a2 335ee99a4aae9522d55220b1a17b14a9e0a98b9b
git push --force-with-lease

github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2025
… CI (#29078)

# Description
Backport of #29005 to `stable/8.7`.

relates to
github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2025
…er tests in the common CI (#29086)

# Description
Backport of #29078 to `stable/8.6`.

relates to #29005
@korthout korthout added the version:8.7.0 Marks an issue as being completely or in parts released in 8.7.0 label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport stable/8.6 Backport a pull request to stable/8.6 backport stable/8.7 Backport a pull request to stable/8.7 component/build-pipeline component/tasklist Related to the Tasklist component/team version:8.6.11 version:8.7.0 Marks an issue as being completely or in parts released in 8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants