-
Notifications
You must be signed in to change notification settings - Fork 736
ci: include Tasklist docker tests in the common CI #29005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da23fe5 to
7616618
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1b26a5c to
16ee695
Compare
b99ebf1 to
4e1cf60
Compare
4e1cf60 to
428d7af
Compare
ChrisKujawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
|
I will have a look but might not make it today since I'm feeling sick-ish.
Do you think backporting to stable 8.6 and 8.7 makes sense for this? Those branches also have the Unified CI and no required Tasklist status check. |
There is no urgency, Get Well Soon!
yes, it makes sense to backport it. |
cmur2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution!
5a65d8a to
335ee99
Compare
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-29005-to-stable/8.6
git worktree add --checkout .worktree/backport-29005-to-stable/8.6 backport-29005-to-stable/8.6
cd .worktree/backport-29005-to-stable/8.6
git reset --hard HEAD^
git cherry-pick -x 428d7afe243fc253b34bdd6b7a611201edb7c5a2 335ee99a4aae9522d55220b1a17b14a9e0a98b9b
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-29005-to-stable/8.7
git worktree add --checkout .worktree/backport-29005-to-stable/8.7 backport-29005-to-stable/8.7
cd .worktree/backport-29005-to-stable/8.7
git reset --hard HEAD^
git cherry-pick -x 428d7afe243fc253b34bdd6b7a611201edb7c5a2 335ee99a4aae9522d55220b1a17b14a9e0a98b9b
git push --force-with-lease |
Description
This PR addresses a recent issue where the Tasklist application failed to start due to changes that were merged without being blocked by the Tasklist Docker tests workflow, as it is not a required check.
To avoid that, we are integrating Tasklist Docker tests into the common CI. This includes:
The job takes around 8-9 minutes in average, I set the timeout to 15 minutes
This will replace the existing
build-tasklist-backendjob in the common CI, as it contains similar steps.Checklist
Related issues
closes #