Skip to content

build: remove non-optimize CIs #27352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
buccarel merged 3 commits into from
Jan 23, 2025
Merged

build: remove non-optimize CIs #27352

buccarel merged 3 commits into from
Jan 23, 2025

Conversation

@buccarel
Copy link
Contributor

@buccarel buccarel commented Jan 23, 2025 •
edited
Loading

Description

As this branch is dedicated to Optimize, we don't need to run the CIs of other teams. This is because the version of Optimize of this branch is not yet integrated in the single application and other CIs would not be useful.

Checklist

Related issues

closes #

@buccarel buccarel self-assigned this Jan 23, 2025
@github-actions github-actions bot added component/build-pipeline component/zeebe Related to the Zeebe component/team component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels Jan 23, 2025
@github-actions github-actions bot added the component/optimize Related to Optimize component/team label Jan 23, 2025
@buccarel buccarel marked this pull request as ready for review January 23, 2025 13:57
@buccarel buccarel requested a review from RomanJRW January 23, 2025 13:59
@RomanJRW
Copy link
Contributor

RomanJRW commented Jan 23, 2025

The approach seems reasonable to me and the CI on this PR seems to verify what we want, but let's have @cmur2 have a look before merging.

Also, shall we do this for the stable/optimize-8.6 branch too? It would save on costs to not run unnecessary things there

@cmur2
Copy link
Member

cmur2 commented Jan 23, 2025

The approach seems reasonable to me and the CI on this PR seems to verify what we want, but let's have @cmur2 have a look before merging.

Looking at the list of removed jobs I think it should be fine if the branch is totally dedicated to Optimize. Since this change is reversible (in case we later identify some CI jobs would've been good to keep) I'm 👍🏼

Also, shall we do this for the stable/optimize-8.6 branch too? It would save on costs to not run unnecessary things there

The same reasoning applies to stable/optimize-8.6 indeed from my perspective.

grlimacan
grlimacan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@grlimacan grlimacan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

grlimacan
grlimacan reviewed Jan 23, 2025
View reviewed changes
@buccarel buccarel merged commit ef3cfaa into stable/optimize-8.7 Jan 23, 2025
7 checks passed
@buccarel buccarel deleted the disable-non-optimize-ci branch January 23, 2025 15:16
@buccarel buccarel mentioned this pull request Jan 23, 2025
Merged
3 tasks
buccarel added a commit that referenced this pull request Jan 23, 2025
@buccarel
build: remove non-optimize CIs (#27387)
5289282 
## Description

This is the equivalent of #27352
but for 8.6 instead of 8.7.

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] for CI changes:
- [ ] structural/foundational changes signed off by [CI
DRI](https://github.com/cmur2)
- [ ]
[ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml)
modifications comply with ["Unified CI"
requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria)

## Related issues

closes #
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomanJRW RomanJRW Awaiting requested review from RomanJRW

1 more reviewer

@grlimacan grlimacan grlimacan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@buccarel buccarel

Labels

component/build-pipeline component/operate Related to the Operate component/team component/optimize Related to Optimize component/team component/tasklist Related to the Tasklist component/team component/zeebe Related to the Zeebe component/team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@buccarel @RomanJRW @cmur2 @grlimacan