feat: remove the optimize db version checker on startup and upgrade #26743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component/optimize
11 tasks
grlimacan
approved these changes
Jan 10, 2025
Contributor
grlimacan
left a comment
grlimacan
left a comment
There was a problem hiding this comment.
LGTM! Only thing I wonder is that you were able to remove the semver dependency on the original PR, but here you rightfully did not, because other files still refer to it. Do those files no longer exist in main?
Contributor
Author
|
@grlimacan - I did not spend much time evaluating that, but I believe it is still referenced on main in the upgrade module, but not on the backend one. So I was able to remove it there. It might be removable here too tbh, I can look at that |
Contributor
Author
|
Merging based on discussion here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #26311
Manual backport of #26592
Description
Checklist
Related issues
related to #26311