Skip to content

Add HTTP-429 for quality-on-demand#306

Merged
hdamker merged 6 commits intocamaraproject:mainfrom
maxl2287:feature/update-http-status-codes
Jul 18, 2024
Merged

Add HTTP-429 for quality-on-demand#306
hdamker merged 6 commits intocamaraproject:mainfrom
maxl2287:feature/update-http-status-codes

Conversation

@maxl2287
Copy link
Copy Markdown
Collaborator

@maxl2287 maxl2287 commented Jun 20, 2024

What type of PR is this?

  • enhancement

What this PR does / why we need it:

This PR adds additional HTTP status codes to the QoD APIs.

  • 429: Too Many Requests

Which issue(s) this PR fixes:

Fixes #305

@maxl2287 maxl2287 requested a review from RandyLevensalor July 10, 2024 19:46
@hdamker
Copy link
Copy Markdown
Collaborator

hdamker commented Jul 11, 2024

@jlurien Could you please check, especially if the definition of 429 fits for you and will make #297 obsolet?

eric-murray
eric-murray previously approved these changes Jul 12, 2024
@maxl2287 maxl2287 changed the title Add HTTP-status-codes for better Error Handling Add HTTP-429 for quality-on-demand Jul 12, 2024
@maxl2287
Copy link
Copy Markdown
Collaborator Author

@hdamker updated to remove 429 from qos-profiles.

@maxl2287 maxl2287 requested a review from eric-murray July 12, 2024 21:26
@hdamker hdamker requested a review from jlurien July 13, 2024 15:20
@hdamker
Copy link
Copy Markdown
Collaborator

hdamker commented Jul 13, 2024

@jlurien Please review as discussed within the QoD meeting

Copy link
Copy Markdown
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more HTTP Status Codes for improved Error Handling

5 participants