Skip to content

CAMARA-API-access-and-user-consent.md aligment with last decisions made in profile#155

Merged
jpengar merged 3 commits intomainfrom
jpengar/API-access-and-user-consent-doc-clean-up
May 30, 2024
Merged

CAMARA-API-access-and-user-consent.md aligment with last decisions made in profile#155
jpengar merged 3 commits intomainfrom
jpengar/API-access-and-user-consent-doc-clean-up

Conversation

@jpengar
Copy link
Copy Markdown
Collaborator

@jpengar jpengar commented May 16, 2024

What type of PR is this?

  • cleanup
  • documentation

What this PR does / why we need it:

Clean up and update the CAMARA-API-access-and-user-consent.md document to reflect the latest profile decisions and/or to include references(*) to the new CAMARA-Security-Interoperability.md profile document where appropriate.

Which issue(s) this PR fixes:

Fixes #154
Fixes #131

Special notes for reviewers:

  • @hdamker Please review, because I think this PR would be fixing issue Inconsistent statements about applicable authorization flows #131 as well.
  • Please, reviewers are encouraged to review the PR content considering the scope of the issue(s) being addressed. If there is another topic related to the document that someone needs to discuss, please open a new issue to address it if it does not already exist.

Changelog input

 `CAMARA-API-access-and-user-consent.md` aligment with profile

Additional documentation

N/A

@jpengar jpengar requested review from hdamker and sebdewet May 16, 2024 10:13
@jpengar jpengar requested a review from AxelNennker as a code owner May 16, 2024 10:13
@jpengar jpengar mentioned this pull request May 16, 2024
Closed
@jpengar jpengar added documentation Improvements or additions to documentation v0.2-candidate Custom label for issues that are candidates to be fixed in v0.2 (if needed) labels May 16, 2024
This was referenced May 16, 2024
Closed
Closed
Merged
Closed
@jpengar
Copy link
Copy Markdown
Collaborator Author

jpengar commented May 23, 2024 •
edited
Loading

As mentioned in the ICM meeting on 22nd May, I would like to close this PR that was opened last week (16/05), and to do so a reasonable deadline will be set for receiving further comments. So if there is no feedback until 29/05 (end of day), I will merge the PR. Please review.

@jpengar jpengar mentioned this pull request May 28, 2024
Closed
@jpengar
Copy link
Copy Markdown
Collaborator Author

jpengar commented May 30, 2024

Thanks @sebdewet for your review!
I'm merging this PR as we've already passed the deadline. No further comments were received.

@jpengar jpengar merged commit 681e65f into main May 30, 2024
@hdamker
Copy link
Copy Markdown
Collaborator

hdamker commented Jun 2, 2024

@jpengar changes are looking good to me as well. Just the remark that all references to https://github.com/camaraproject/IdentityAndConsentManagement/blob/main/documentation/CAMARA-Security-Interoperability.md should be in the in the released version to the concrete release. Maybe a relative link could be an alternative: ./CAMARA-Security-Interoperability.md as it will point always to the same tree? But have not tested it.

@jpengar jpengar deleted the jpengar/API-access-and-user-consent-doc-clean-up branch August 29, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebdewet sebdewet sebdewet approved these changes

@hdamker hdamker Awaiting requested review from hdamker

@AxelNennker AxelNennker Awaiting requested review from AxelNennker AxelNennker is a code owner

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation v0.2-candidate Custom label for issues that are candidates to be fixed in v0.2 (if needed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"CAMARA-API-access-and-user-consent.md" aligment with last decisions made in profile doc Inconsistent statements about applicable authorization flows

3 participants

@jpengar @hdamker @sebdewet