Skip to content

Fix Typo in Gherkin Device Errors Template#523

Merged
PedroDiez merged 2 commits intocamaraproject:mainfrom
PedroDiez:fix_typo_gherkin_device_error_template
Sep 3, 2025
Merged

Fix Typo in Gherkin Device Errors Template#523
PedroDiez merged 2 commits intocamaraproject:mainfrom
PedroDiez:fix_typo_gherkin_device_error_template

Conversation

@PedroDiez
Copy link
Copy Markdown
Contributor

What type of PR is this?

  • bug
  • correction

What this PR does / why we need it:

Fix typo in C01-device-errors.feature. It should read: {path_to_device}.networkAccessIdentifier

Which issue(s) this PR fixes:

Fixes #522

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

N/A

Changelog input

 Fix Typo in Gherkin Device Errors Template

Additional documentation

N/A

@PedroDiez PedroDiez self-assigned this Sep 1, 2025
@rartych rartych added the correction correction in documentation label Sep 2, 2025
rartych
rartych previously approved these changes Sep 2, 2025
Copy link
Copy Markdown
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych mentioned this pull request Sep 2, 2025
Copy link
Copy Markdown
Contributor

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat selection, now it appears as

            | device_identifier                  | oas_spec_schema                             |
            | {path_to_device}.phoneNumber       | /components/schemas/PhoneNumber             |
            | {path_to_device}.ipv4Address       | /components/schemas/DeviceIpv4Addr          |
            | {path_to_device}.ipv6Address       | /components/schemas/DeviceIpv6Address       |
            | {path_to_device}.networkAccessIdentifier | /components/schemas/NetworkAccessIdentifier |

Copy link
Copy Markdown
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reformatting

Copy link
Copy Markdown
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez PedroDiez merged commit 6fca693 into camaraproject:main Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

correction correction in documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correction of typo in Gherkin template for device errors

4 participants