Update types property of Subscription schema in event-subscription-template.yaml#432
Merged
rartych merged 4 commits intocamaraproject:mainfrom Apr 30, 2025
Merged
Conversation
eric-murray
requested review from
PedroDiez,
jlurien,
patrice-conil,
rartych and
shilpa-padgaonkar
as code owners
PedroDiez
reviewed
Mar 20, 2025
Contributor
PedroDiez
left a comment
PedroDiez
left a comment
There was a problem hiding this comment.
LGTM.
Just a minor comment
bigludo7
approved these changes
Apr 22, 2025
Collaborator
bigludo7
left a comment
bigludo7
left a comment
There was a problem hiding this comment.
LGTM
We had exactly same request in Geofencing API ;)
PedroDiez
previously approved these changes
Apr 25, 2025
Contributor
PedroDiez
left a comment
PedroDiez
left a comment
There was a problem hiding this comment.
LGTM
have made the commit to align @eric-murray
Please @patrice-conil you can give LGTM again
Contributor
|
I propose to update also |
Contributor
|
HI @PedroDiez, LGTM also , but waiting for change in 2.2.3 as requested by @rartych |
Collaborator
Author
|
CAMARA-API-Event-Subscription-and-Notification-Guide.md updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The
Subscription.typesproperty in event-subscription-template.yaml is currently defined as a string, But the response values must be one of those defined by theSubscriptionEventTypeschema. This PR makes that explicit.In addition, the description is updated, as Commonalities is now at version 0.5, and hence API sub-projects are free to decide to allow more than one event type per subscription.
Which issue(s) this PR fixes:
Fixes # N/A
Does this PR introduce a breaking change?
Special notes for reviewers:
None
Changelog input
Additional documentation
None