Sink format corrected and indicated in API Design Guidelines#414
Merged
rartych merged 4 commits intocamaraproject:mainfrom Feb 18, 2025
Merged
Sink format corrected and indicated in API Design Guidelines#414rartych merged 4 commits intocamaraproject:mainfrom
rartych merged 4 commits intocamaraproject:mainfrom
Conversation
rartych
requested review from
PedroDiez,
RubenBG7,
patrice-conil and
shilpa-padgaonkar
as code owners
rartych
commented
Feb 10, 2025
eric-murray
approved these changes
Feb 11, 2025
bigludo7
approved these changes
Feb 17, 2025
Collaborator
bigludo7
left a comment
bigludo7
left a comment
There was a problem hiding this comment.
LGTM
On behalf of @patrice-conil for Orange
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Correction in event subscription template to format sink string as URI as defined in Cloudevents Subscriptions specification
The required string format added to sink definitions in API Design Guidelines.
Which issue(s) this PR fixes:
Fixes #391
Does this PR introduce a breaking change?
The
urlformat used in the event subscription template was non-standard, but imposed similar restrictions.Special notes for reviewers:
Requirements for
uri-referenceoruriformat for parameters containing URL can be added to https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#115-data-definitionsChangelog input
Additional documentation