Skip to content

Updated message field and description for Error 429#390

Merged
rartych merged 4 commits intocamaraproject:mainfrom
rartych:quota
Jan 24, 2025
Merged

Updated message field and description for Error 429#390
rartych merged 4 commits intocamaraproject:mainfrom
rartych:quota

Conversation

@rartych
Copy link
Copy Markdown
Contributor

@rartych rartych commented Jan 22, 2025

What type of PR is this?

  • correction

What this PR does / why we need it:

For different error codes identical error message was used.

The changes distinguish:

  • 429 QUOTA_EXCEEDED for business quota limit
  • 429 TOO_MANY_REQUESTS for rate limiting (e.g., per minute, per hour, per day) or spike arrest limits

Which issue(s) this PR fixes:

Fixes #372

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

Updated message  and description for Error 429

Additional documentation

@rartych rartych marked this pull request as ready for review January 22, 2025 15:51
@rartych rartych requested a review from Kevsy January 22, 2025 15:52
@rartych rartych added documentation Improvements or additions to documentation Spring25 labels Jan 22, 2025
Copy link
Copy Markdown
Collaborator

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rartych

Copy link
Copy Markdown
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Spring25

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More explicit error message for errro 429 QUOTA_EXCEEDED/TOO_MANY_REQUESTS

3 participants