Skip to content

Update Subscription Security Considerations#277

Merged
rartych merged 2 commits intocamaraproject:mainfrom
AxelNennker:patch-3
Feb 14, 2025
Merged

Update Subscription Security Considerations#277
rartych merged 2 commits intocamaraproject:mainfrom
AxelNennker:patch-3

Conversation

@AxelNennker
Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

CloudEvents cares about interoperability and supports many protocols and event data formats.
Therefore the CloudEvent Security and Privacy considerations are quite general and vague.
Currently Camara does not follow the CloudEvents recommendation that event data should be protected through signature and encryption.

This PR provides security considerations for API Consumers and Notification Senders.

Fixes #218

Copy link
Copy Markdown
Contributor

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @AxelNennker
LGTM

Copy link
Copy Markdown
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Proposed extended considerations are "recommendations" - further feedback expected from API developers.

@PedroDiez
Copy link
Copy Markdown
Contributor

One comment, this is a recommendation, right? it is not a MUST.

We need to discuss this further on the fact about how to sign the information within the request body

@rartych rartych mentioned this pull request Jan 28, 2025
2 tasks
@PedroDiez
Copy link
Copy Markdown
Contributor

OK as an initial recommendation. Some points to be discussed in the future:

  • Signing of whole notification body
  • Procedure for obtaining/querying keys

Copy link
Copy Markdown
Contributor

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit d15fef2 into camaraproject:main Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a meaningful security-considerations section

4 participants