reformat tables, grammar and style issues in documentation-files#234
Merged
rartych merged 7 commits intocamaraproject:mainfrom Jul 2, 2024
Merged
Conversation
maxl2287
requested review from
PedroDiez,
RubenBG7,
patrice-conil,
rartych and
shilpa-padgaonkar
as code owners
maxl2287
changed the title
maxl2287
changed the title
patrice-conil
previously approved these changes
Jun 12, 2024
Contributor
patrice-conil
left a comment
patrice-conil
left a comment
There was a problem hiding this comment.
Not good enough in English to judge these subtle changes so LGTM
PedroDiez
previously approved these changes
Jun 18, 2024
Contributor
PedroDiez
left a comment
PedroDiez
left a comment
There was a problem hiding this comment.
minor comment
LGTM in advance
Co-authored-by: Pedro Díez García <[email protected]>
…rmat-tables-styles-grammars-in-mds # Conflicts: # documentation/API-Readiness-Checklist.md # documentation/API-Testing-Guidelines.md
Contributor
Author
|
@PedroDiez updated your typo-hint and resolve the merge conflicts. |
PedroDiez
reviewed
Jun 19, 2024
Contributor
PedroDiez
left a comment
PedroDiez
left a comment
There was a problem hiding this comment.
A couple of comments regarding API testing guidelines
Co-authored-by: Pedro Díez García <[email protected]>
Co-authored-by: Pedro Díez García <[email protected]>
…rmat-tables-styles-grammars-in-mds # Conflicts: # documentation/Camara_Versioning_Guidelines.md
rartych
approved these changes
Jul 1, 2024
Contributor
|
Merging as commonly approved (the last commits resolved conficts) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR is a fixing of some style and reference-issues
Which issue(s) this PR fixes:
Fixes #232