fix(metadata): Remove Duplicate Site Names from Page Titles#30
Merged
Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
This PR addresses duplicate site names in page titles (e.g., "Research | Caltech MSC | Caltech MSC") by refactoring the metadata generation system. The approach delegates title template formatting to Next.js layouts using the title.template feature, eliminating manual concatenation that caused duplicates.
Changes:
- Refactored
createPageMetadatato return clean titles without manual site name concatenation, delegating template formatting to layouts - Centralized title templates in root and admin layouts using Next.js
title.templatefeature - Removed
seoDefaultsexport from site configuration, moving its logic to metadata functions and layouts
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/metadata.ts | Refactored to remove manual title concatenation and seoDefaults import; simplified to use conditional metadata spreading |
| src/config/site.ts | Removed seoDefaults export as logic moved to metadata.ts and layouts |
| src/app/admin/(authenticated)/layout.tsx | Added title template for admin pages: %s | Admin | ${siteConfig.name} |
| src/app/admin/(authenticated)/page.tsx | Removed " |
| src/app/admin/(authenticated)/sync/page.tsx | Removed " |
| src/app/admin/(authenticated)/research/page.tsx | Removed " |
| src/app/admin/(authenticated)/publications/page.tsx | Removed " |
| src/app/admin/(authenticated)/photos/page.tsx | Removed " |
| src/app/admin/(authenticated)/members/page.tsx | Removed " |
| src/app/admin/(authenticated)/members/categories/page.tsx | Removed " |
| src/app/admin/(authenticated)/collaborators/page.tsx | Removed " |
| src/app/admin/(authenticated)/admins/page.tsx | Removed " |
| src/app/(public)/events/photos/page.tsx | Updated to use centralized pageDescriptions.photos constant |
| src/app/(public)/events/calendar/page.tsx | Updated to use centralized pageDescriptions.calendar constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lusion and defaults
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Corrected an issue where page titles were displaying duplicate site names (e.g., "Research | Caltech MSC | Caltech MSC") by refactoring the metadata generation utility. This change ensures clean, SEO-friendly titles by delegating the title template formatting to the root layout, rather than manually appending the site name in every page's metadata function.
Changes:
Refactored
createPageMetadata(src/lib/metadata.ts):Centralized Title Template (
src/app/layout.tsx):%s | Caltech MSC) to the root layout metadata export.Caltech MSC) for the root page.Updated Page Metadata:
admins,collaborators,members,photos,publications,research,sync).calendar,photos) to usepageDescriptionsconstants for consistency.Cleaned Up Configuration:
seoDefaultsfromsrc/config/site.tsas its logic is now handled more robustly withinmetadata.tsandlayout.tsx.