feat: toContainElement matcher
#1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siepra
changed the title
toContainElement matchertoContainElement matcher
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
+ Coverage 98.08% 98.09% +0.01%
==========================================
Files 93 94 +1
Lines 5590 5630 +40
Branches 864 873 +9
==========================================
+ Hits 5483 5523 +40
Misses 107 107
☔ View full report in Codecov by Sentry. |
19 tasks
Contributor
Author
|
@mdjastrzebski could you spare a minute to review this one? |
Member
|
@siepra will do it soon, at the moment the PR queue extends my capacity to zero it in one day, so I'll handling it in the FIFO order. |
Contributor
Author
|
@mdjastrzebski I didn't mean to hurry you up, just thought you might have missed it (as I didn't explicitly linked this PR in the main issue). Good luck with all the reviews! |
mdjastrzebski
force-pushed
the
feat/toContainElement-matcher
branch
from
6177070 to
a383a34
Compare
mdjastrzebski
approved these changes
Sep 19, 2023
Member
mdjastrzebski
left a comment
mdjastrzebski
left a comment
There was a problem hiding this comment.
All good, let's ship it ✅
Member
|
🎉 Release in version: v12.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1486 - Implement
toContainElement()matcher.Based on Jest Native's toContainElement()
Test plan
yarn test