fix: flatlist not rendering in rntl repo #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 76 76
Lines 4493 4493
Branches 647 647
=======================================
Hits 4368 4368
Misses 125 125 ☔ View full report in Codecov by Sentry. |
mdjastrzebski
approved these changes
Aug 22, 2023
Member
mdjastrzebski
left a comment
mdjastrzebski
left a comment
There was a problem hiding this comment.
Great work @pierrezimmermannbam! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1449
Because of the babel plugin for class properties (see this comment on the react native repo), rendering a flatlist would result in an error. Removing the plugin fixes the error, although I'm not sure why because that plugin is included in babel/preset-env for versions > 7 so we should have it no matter what. It may be an issue with different versions of the plugin, I haven't really understood what was the exact problem, I've tried to look at the transpiled files using the babel cli but they look exactly the same
Test plan
I added a test case for rendering a flatlist and all tests are passing