Skip to content

refactor(sdk): require explicit hosts in 0.22 - #4521

Merged
thymikee merged 3 commits into
0.22from
t3/remove-ambient-sdk-defaults
Nov 13, 2026
Merged

thymikee merged 3 commits into
0.22from
t3/remove-ambient-sdk-defaults

Conversation

@thymikee

@thymikee thymikee commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Part of #3759 section 3. Require explicit SDK hosts, remote-config env and artifact-adapter cwd. Preserve executable and optional startAgentDevice captures.

const host = { env: { ...process.env }, cwd: process.cwd() };
await resolveAndroidArchivePackageName('./app.apk', host);

56 files against 0.22, including migration docs and a changeset. The review fix preserves request overlays only for the identical host and passes archive cwd to both unzip and aapt. Examples and installed-package fixtures use the required inputs. Duplicate API listings and enforced guidance were removed without changing guard limits.

Validation

Head: 74af35d752189384ca25437ef026f7c6733ca455; reviewed parent: 7af51db34b1c68bf2775427e6638aeac8295f552; integration base: 4d75aa414f00b8a3a33b61a804f1baad3d25ee58.

Three new regressions failed before fixes: same-host overlay, relative-PATH unzip and aapt cwd. All pass after fixes. Local focused suites: 37 tests; guidance: five; compiled documentation snippets and installed package: nine. Frozen install/build, typecheck, lint, full-repo format and prose checks passed. Original 73 runtime/13 boundary results belong to 7af51db.

Earlier hosted failures covered stale Limrun/artifact signatures, duplicate documentation and guidance budget; those owners are corrected. Independent source recheck approved this head, including Size growth. Hosted CI passed. Full serialized validation passed: 41 checks, 25 owner-declared skips, exactCommit=true, checkoutChanged=false (receipt run-4y357w); 19,751 unit and 288 provider tests passed. No live-device evidence is claimed. Host subprocess regressions use real fixture executables.

Independent source review approved this head. Integration is limited to 0.22.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.25 MB 6.25 MB +4.2 kB
Package (unpacked) 6.25 MB 6.25 MB +4.2 kB
Package (download) 1.90 MB 1.90 MB +813 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 48.6 ms 44.2 ms -4.5 ms
CLI --help 101.1 ms 84.9 ms -16.2 ms

@thymikee
thymikee marked this pull request as ready for review November 13, 2026 22:05
@thymikee
thymikee merged commit e29ed5d into 0.22 Nov 13, 2026
20 of 21 checks passed
@thymikee
thymikee deleted the t3/remove-ambient-sdk-defaults branch November 13, 2026 22:06
thymikee added a commit that referenced this pull request Nov 14, 2026
* refactor(sdk): require explicit host dependencies in 0.22

* chore(gates): remove ambient SDK process entry waivers

* fix(sdk): preserve request overlays and archive working directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant