You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(daemon): require runtime access when constructing request execution - #4061
Require the runtime gateway and platform request scope when constructing request execution, so incomplete wiring cannot disable claim admission or become a late runtime error. Update the direct scope fixtures to use the same construction path.
11 files changed. No scope expansion. Closes#4047; part of #4045.
Validation
Head: 8380273dff87bc5f616400437d10306fc9b31281.
Frozen install/build, format and typecheck passed.
Nightly concurrency runner: 4 passed, including 128 seeded interleavings.
Independent review: no findings. No assertions required changes; construction fixtures were updated, and claim-admission assertions were unchanged.
Exact-head affected gate failed in the provider recording scenario: 1 failed / 1,985 passed tests. The identical command on unchanged base 144bd59890277fd4717995588ad817597c9d6552 reproduced that timeout (3 failed / 1,983 passed overall).
Merged after review. The historical local gate was base-blocked by #4060; that result is not relabeled as a pass. Production already supplied both construction dependencies; no live device behavior changed.
The code in 8380273 looks good: I found no problems with requiring runtime access when constructing request execution. All 17 checks pass at this commit, and there are no conflicts. I did not run tests or typecheck locally; I relied on green CI and the type change for the claim that every caller compiles, and I did not trace each touched test to confirm none binds a device under transient-exclusive policy. Not blocking, and you can take or leave it: issue #4047 asks to report tests whose old assertions depended on bypassed admission, and the PR body lists validation counts but does not say which of the 10 touched files needed assertion changes (apparently none), so one line there would close it (request-execution-scope.ts#L221). The PR is still a draft and depends on #4060 per its body, so mark it ready once #4060 lands and the affected gate passes on the exact head.
Addressing the review note: none of the touched fixtures needed an assertion change. They now supply the gateway and request scope; the claim-admission suites and their assertions were unchanged. I have added this audit result to the PR description. The historical local gate failure remains recorded as a failure even though the PR has since merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thymikee
added
the
ready-for-human
Summary
Require the runtime gateway and platform request scope when constructing request execution, so incomplete wiring cannot disable claim admission or become a late runtime error. Update the direct scope fixtures to use the same construction path.
11 files changed. No scope expansion. Closes #4047; part of #4045.
Validation
Head:
8380273dff87bc5f616400437d10306fc9b31281.144bd59890277fd4717995588ad817597c9d6552reproduced that timeout (3 failed / 1,983 passed overall).Merged after review. The historical local gate was base-blocked by #4060; that result is not relabeled as a pass. Production already supplied both construction dependencies; no live device behavior changed.