Skip to content

Commit f688878

Browse files
thymikeeclaude
andcommitted
ci(diagnose): retire the 1874 diagnose loop
The loop's default test stopped reaching a commit wait in #2845: it asserts route xctest-element, so a default dispatch collects no [DEBUG-1874] cadence. That test never reached #2080's route, even before #2845. It is a bare `type`, and the synthesized-first-responder-replacement route fires only for `fill` on a penalized XCTest channel. So this loop was never #2080's reproduction path. No existing RunnerTests method reaches the real replacement route. The one test that reaches its commit wait (testTypeTextReliablyPacesSynthesizedReplacementThroughProductionCaller) uses a recording synthesizer against Springboard, so every poll reads nil and the wait always ends notObserved at the 3 s stall deadline. Looping it records a fixed, synthetic cadence. A new penalized coordinate-fill test could reach the route, but the cadence records lengths only (#1924), so it still could not capture the corrupted value #2080 needs. #2080's triage asks for a local reproduction with test-only value instrumentation instead. Delete the workflow, its iteration reader, and that reader's test. The runner's [DEBUG-1874] lines stay: runner.log in the iOS smoke lane is where the #2080 trace came from, and existing tests pin their format and redaction. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 5c19230 commit f688878

4 files changed

Lines changed: 0 additions & 370 deletions

File tree

‎.github/workflows/1874-diagnose.yml‎

Lines changed: 0 additions & 132 deletions
This file was deleted.

‎scripts/__tests__/diagnose-1874-iteration.test.ts‎

Lines changed: 0 additions & 157 deletions
This file was deleted.

‎scripts/diagnose-1874-iteration.ts‎

Lines changed: 0 additions & 80 deletions
This file was deleted.

‎vitest.config.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ export default defineConfig({
163163
// Parses CI configuration only, so this action guard needs no device or subprocess lane.
164164
'test/ci/upload-agent-device-artifacts.test.ts',
165165
'test/ci/upload-artifact-hidden-paths.test.ts',
166-
'scripts/__tests__/diagnose-1874-iteration.test.ts',
167166
// The size reporter is preserved across a base checkout; its entrypoint and imported
168167
// modules must move as one directory or the Bundle Size lane fails before measuring.
169168
'test/ci/size-workflow.test.ts',

0 commit comments

Comments
 (0)