Skip to content

Commit f633525

Browse files
authored
docs(adr): write the replay ADR and proposed ADRs in ASD-STE100 (#3730)
* docs(adr): remove completed ADR 0012 guidance history * docs(adr): write ADR 0012 §Status, summary, and decisions 1-2 in ASD-STE100 * docs(adr): write ADR 0012 §3 in ASD-STE100 * docs(adr): write ADR 0012 §4 in ASD-STE100 * docs(adr): write ADR 0012 §5 in ASD-STE100 * docs(adr): write ADR 0012 §6 in ASD-STE100 * docs(adr): write ADR 0012 §Consequences, alternatives, and context in ASD-STE100 * docs(adr): write ADR 0018 in ASD-STE100 * docs(adr): write ADR 0020 in ASD-STE100 * docs(adr): remove completed ADR 0024 rollout history * docs(adr): write ADR 0024 in ASD-STE100 * docs(adr): write ADR 0028 in ASD-STE100 * docs(adr): simplify ADR 0024 matrix prose in ASD-STE100 * docs(adr): repair verified replay and journal source pointers * docs(adr): restore the frozen meaning in ADR 0028 Restore the base meaning that the ASD-STE100 rewrite changed: - An owner that does not state a cell is a bug. The rewrite said "a missing owner declaration", which collides with provider ownership gaps. - Restore the withdraw rule: if the gate stays red, withdraw the ADR and give no exception. - Restore the duty to report files touched for the measured family. - Restore "never assigns lifecycle semantics" and "lifecycle stays out of the table", "every runtime owner", "stop" the fan-out, "rather than arguing from the shape", and "rather than invent". * docs(adr): restore the frozen meaning in ADR 0018 Restore the base meaning that the ASD-STE100 rewrite changed: - Upload progress "never crosses the request scope". The rewrite said "within request scope", which inverted the rule. - Keep the proposal frame: emit() keeps the four existing steps and "would" offer events to sinks; the shard fork rules and the fork tree are proposed, not existing. - Restore "every consumer is a sink", the closed list of absorbed kinds, the UsageRecord field vocabulary, "opt-in export", "request finalization", "single declaration site", "listed in one place", and "worse than the status quo". - Restore the events.ndjson target in the teardown validation, the fixture in the redaction validation, and "out of scope and rejected" for state recovery. - Point session-test-runtime.ts at packages/replay-test/src/internal/ and RequestProgressEvent at packages/contracts/src/request-progress.ts. * docs(adr): restore the frozen meaning in ADR 0020 Restore the base meaning that the ASD-STE100 rewrite changed: - compositionDigest is SHA-256 over the root plan, the ordered include call-site semantics, and the pinned expected identities. - Source-closure preflight runs first. Request-level checks apply only after a valid composition digest exists. DEVICE_IN_USE stays reserved for a device that another session claims. - Restore "existing" for the dispatchKnownCommand seam, "native" on missing/changed fragments, and "identity-bearing" on the guard wait. - Restore "trust the production change", the test assertions in the Maestro slice, and the packages/maestro/src/internal/__tests__/ directory for source-closure and program-loader tests. - Re-audit fixes: "the useful lever is the unit", "allowed subject to" cycle detection, "not a hash of every file", "fail closed", the unchanged-child-move rule, "never compared for authorization", the fragment codec owner of the planted-red tests, the divergence address that the agent receives, the reuse-win and failure-usefulness consequences, and "Composition is one semantic model, not one engine". * docs(adr): restore the frozen meaning in ADR 0024 Restore the base meaning that the ASD-STE100 rewrite changed: - Native markers keep their platform owners: owned-processes.json covers simulator recorders; the Android marker covers launch and chunk rotation. - Split "retain ownership-fence-lost" from "retain the union for the other kinds". - Remove the "this proposal defines" intro from the matrix, so the existing Limrun row does not read as proposed, and restore the base matrix cells, including "to the output path". - Restore the backend as verifier of native-artifact absence ("only after"), the per-kind gate in rollout step 2, "the manifest remains enumerable", the owner named in the manifest, the reaper, "since July", "user-facing", "no refusal that a silent host or a reused pid can produce", and "no row of the table in section 1". - Re-audit fixes: restore the base cells of the rules and compatibility tables, "this section 2.7" for the ADR 0019 pointer, "Reattachment is already dead", "all the reported failures", "Signalling lives entirely inside the backend", the removed proposal frames that ADR 0024 did not have, and the per-target live-proof list. * docs(adr): restore the frozen meaning in ADR 0012 Restore the base meaning that the ASD-STE100 rewrite changed: - R3: the daemon computes repairHint at divergence time; the agent never computes it. The rewrite said "not alone". - "--from must never repeat steps 1..N-1" is absolute again; the rewrite made it conditional on non-idempotent scripts. - #1567: either endpoint failure refuses the whole action; #1385: the retry is opt-in per call site and other callers do not change; viewportOrder uses the recorded scrollRegion partition, or none when it is omitted. - Name the transaction and repairSessionHeld explicitly; restore the manual-completion case in the resume loop; repairHint tests cover all four hints and kinds (not every combination); R6 and #1271 exclusions are "from the healed script"; top-level wait is "not in this set". - Restore the enum values and field names in the rules summary, "pre-acceptance migration plan", "only", "if and only if", "must be in range", "does not" keep the session live, "only after these contracts pass", "for any kind", the hand-edit surface as a decision 1 fallback, the exact Maestro failure quote, and "Direct-iOS". - Re-audit fixes: "never file behavior", "strictly more valuable", "removed, not tuned", "by construction", "a divergent step is never pushed", the #1287 stage-1 history, the grammar rejection of every unsupported --record use, the named-helper capability, "not heal" in audit (b), the quoted "insufficient foreground app content" helper output, and straight quotes instead of curly quotes. * docs(adr): keep the sibling signal from filtering the ADR 0012 identity set The STE rewrite said the sibling signal "retains" members of I, which reads as a filter before viewportOrder. The base text only finds qualifying members and falls through with the same candidate domain. Found in review round 2.
1 parent ffee792 commit f633525

5 files changed

Lines changed: 2929 additions & 2390 deletions

0 commit comments

Comments
 (0)