Skip to content

Commit f5abcf6

Browse files
test(daemon): pass claim data as plain view accessors (fallow)
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent f9e423f commit f5abcf6

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎test/integration/concurrency-torture/harness.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,8 @@ class TortureWorld {
152152
...checkInvariants({
153153
sessionStore: this.sessionStore,
154154
leaseRegistry: this.leaseRegistry,
155-
claims: this.claims,
155+
claimSnapshot: this.claims.snapshot(),
156+
claimOwner: (deviceKey) => this.claims.ownerSession(deviceKey),
156157
instances: [...this.instances.values()],
157158
isInstanceLive: (instance) => this.isInstanceLive(instance),
158159
deviceActive: this.deviceActive,

‎test/integration/concurrency-torture/invariants.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@
1313
import type { LeaseRegistry } from '../../../src/daemon/lease-registry.ts';
1414
import type { SessionStore } from '../../../src/daemon/session-store.ts';
1515

16-
import type { InMemoryClaimRegistry } from './claim-registry.ts';
1716
import type { SessionInstance } from './bindings.ts';
1817

18+
export type ClaimSnapshot = { deviceKey: string; session: string };
19+
1920
export type InvariantFailure = {
2021
invariant: string;
2122
detail: string;
@@ -25,7 +26,8 @@ export type InvariantFailure = {
2526
export type WorldView = {
2627
sessionStore: SessionStore;
2728
leaseRegistry: LeaseRegistry;
28-
claims: InMemoryClaimRegistry;
29+
claimSnapshot: readonly ClaimSnapshot[];
30+
claimOwner(deviceKey: string): string | undefined;
2931
instances: readonly SessionInstance[];
3032
isInstanceLive(instance: SessionInstance): boolean;
3133
deviceActive: ReadonlyMap<string, number>;
@@ -169,7 +171,7 @@ class InvariantChecker {
169171
}
170172

171173
private checkNoLeakedClaims(): void {
172-
const claims = this.view.claims.snapshot();
174+
const claims = this.view.claimSnapshot;
173175
for (const claim of claims) {
174176
if (!this.view.sessionStore.get(claim.session)) {
175177
this.fail(
@@ -189,7 +191,7 @@ class InvariantChecker {
189191
private checkLiveClaimsHeld(): void {
190192
for (const session of this.view.sessionStore.values()) {
191193
if (!session.deviceClaim) continue;
192-
const owner = this.view.claims.ownerSession(session.deviceClaim.deviceKey);
194+
const owner = this.view.claimOwner(session.deviceClaim.deviceKey);
193195
if (owner !== session.name) {
194196
this.fail(
195197
'no leaked claims',

0 commit comments

Comments
 (0)